Fix formatting errors in webapi module according to PEP8
Review Request #6640 — Created Nov. 24, 2014 and submitted
| Information | |
|---|---|
| justy777 | |
| Review Board | |
| master | |
| 9237d30... | |
| Reviewers | |
| reviewboard, students | |
Fixed the following format errors:
webapi/resources/validate_diff.py:104:22: E201 whitespace after '('
webapi/resources/validate_diff.py:105:22: E128 continuation line under-indented for visual indent
webapi/resources/validate_diff.py:105:25: E201 whitespace after '('
webapi/resources/validate_diff.py:106:25: E128 continuation line under-indented for visual indent
webapi/resources/validate_diff.py:107:25: E128 continuation line under-indented for visual indent
webapi/tests/mixins.py:572:1: E303 too many blank lines (3)
webapi/tests/mixins.py:859:1: E303 too many blank lines (3)
webapi/tests/test_review_request_draft.py:61:5: E303 too many blank lines (2)
Ran unit tests, and pep8.
| Description | From | Last Updated |
|---|---|---|
|
This form is harder to read. I'd ignore the pep8 tool here. Something important to note is that the pep8 … |
 chipx86
|
|
|
Revert these. It's not readable anymore. Same with all below like this. |
chipx86
|
|
|
This is harder to read. Should be reverted to how it was. |
chipx86
|
|
|
Same. |
chipx86
|
-
-
reviewboard/webapi/resources/repository.py (Diff revision 1) This form is harder to read. I'd ignore the pep8 tool here.
Something important to note is that the pep8 tool does two things: 1) It checks code against the PEP-8 spec, and 2) It checks code based on the personal preferences of the author. This is the latter.
-
reviewboard/webapi/resources/review_reply_file_attachment_comment.py (Diff revision 1) Revert these. It's not readable anymore.
Same with all below like this.
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+6 -9) |
17: E126 continuation line over-indented for hanging indent
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_request_draft.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_request_draft.py
-
-
reviewboard/webapi/resources/repository.py (Diff revision 2) This is harder to read. Should be reverted to how it was.
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+4 -7) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_request_draft.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_request_draft.py
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+2 -5) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/test_review_request_draft.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/tests/test_review_request_draft.py
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_request_draft.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/tests/mixins.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/tests/test_review_request_draft.py