Summary

Fix formatting errors in webapi module according to PEP8

Review Request #6640 — Created Nov. 24, 2014 and submitted Nov. 30, 2014, 3:18 p.m.

Information

Owner

justy777

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

9237d30...

Reviewers

Groups

reviewboard, students

People

Description

Fixed the following format errors:
webapi/resources/validate_diff.py:104:22: E201 whitespace after '('
webapi/resources/validate_diff.py:105:22: E128 continuation line under-indented for visual indent
webapi/resources/validate_diff.py:105:25: E201 whitespace after '('
webapi/resources/validate_diff.py:106:25: E128 continuation line under-indented for visual indent
webapi/resources/validate_diff.py:107:25: E128 continuation line under-indented for visual indent
webapi/tests/mixins.py:572:1: E303 too many blank lines (3)
webapi/tests/mixins.py:859:1: E303 too many blank lines (3)
webapi/tests/test_review_request_draft.py:61:5: E303 too many blank lines (2)

Testing Done

Ran unit tests, and pep8.

Issues

Description	From	Last Updated
This form is harder to read. I'd ignore the pep8 tool here. Something important to note is that the pep8 …	chipx86	Nov. 24, 2014, 3:04 p.m.
Revert these. It's not readable anymore. Same with all below like this.	chipx86	Nov. 24, 2014, 3:04 p.m.
This is harder to read. Should be reverted to how it was.	chipx86	Nov. 25, 2014, 3:07 p.m.
Same.	chipx86	Nov. 25, 2014, 3:07 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_request_draft.py

reviewboard/webapi/resources/repository.py (Diff revision 1)

The issue has been resolved. Show all issues

This form is harder to read. I'd ignore the pep8 tool here.

Something important to note is that the pep8 tool does two things: 1) It checks code against the PEP-8 spec, and 2) It checks code based on the personal preferences of the author. This is the latter.

reviewboard/webapi/resources/review_reply_file_attachment_comment.py (Diff revision 1)

The issue has been resolved. Show all issues

Revert these. It's not readable anymore.

Same with all below like this.

Summary:

[WIP] Fix formatting errors in webapi module according to PEP8

Fix formatting errors in webapi module according to PEP8

Description:

		Fixed the following format errors:
-		webapi/resources/repository.py:123:61: E251 unexpected spaces around keyword / parameter equals
-		webapi/resources/review_reply_file_attachment_comment.py:54:18: E251 unexpected spaces around keyword / parameter equals
-		webapi/resources/review_reply_file_attachment_comment.py:55:13: E131 continuation line unaligned for hanging indent
-		webapi/resources/review_reply_file_attachment_comment.py:56:18: E251 unexpected spaces around keyword / parameter equals
-		webapi/resources/review_reply_file_attachment_comment.py:57:13: E131 continuation line unaligned for hanging indent
-		webapi/resources/review_reply_file_attachment_comment.py:123:18: E251 unexpected spaces around keyword / parameter equals
-		webapi/resources/review_reply_file_attachment_comment.py:124:13: E131 continuation line unaligned for hanging indent
		webapi/resources/validate_diff.py:104:22: E201 whitespace after '('
		webapi/resources/validate_diff.py:105:22: E128 continuation line under-indented for visual indent
		webapi/resources/validate_diff.py:105:25: E201 whitespace after '('
		webapi/resources/validate_diff.py:106:25: E128 continuation line under-indented for visual indent
		webapi/resources/validate_diff.py:107:25: E128 continuation line under-indented for visual indent
		webapi/tests/mixins.py:572:1: E303 too many blank lines (3)
		webapi/tests/mixins.py:859:1: E303 too many blank lines (3)
~		webapi/tests/test_file_attachment.py:94:17: E126 continuation line over-indented for hanging indent
	~	webapi/tests/test_review_request_draft.py:61:5: E303 too many blank lines (2)
-		webapi/tests/test_file_attachment.py:285:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_file_attachment_draft.py:176:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_repository.py:358:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_repository_branches.py:58:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review.py:116:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review.py:240:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_comment.py:190:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_comment.py:389:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_group.py:266:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_reply.py:251:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_reply_diff_comment.py:108:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_reply_screenshot_comment.py17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_request.py:1263:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_request_draft.py:61:5: E303 too many blank lines (2)
-		webapi/tests/test_review_request_draft.py:169:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_request_draft.py:194:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_screenshot_comment.py:127:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_review_screenshot_comment.py:255:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_screenshot.py:184:17: E126 continuation line over-indented for hanging indent
-		webapi/tests/test_screenshot_draft.py:70:17: E126 continuation line over-indented for hanging indent
-
-		TODO:
-		Find a good way to fix continuation line over-indented for hanging indent errors

Commit:

573ff94ac588054a4b65c5d821418c658a9d8654

55abae0f437b8599684f8ce0b4bdc5ae2f4885c7

Diff:

Revision 2 (+6 -9)

Show changes

	reviewboard/webapi/resources/repository.py
	reviewboard/webapi/resources/review_reply_file_attachment_comment.py
	reviewboard/webapi/resources/validate_diff.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_request_draft.py

reviewboard/webapi/resources/repository.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This is harder to read. Should be reverted to how it was.
```

reviewboard/webapi/resources/review_reply_file_attachment_comment.py (Diff revision 2)

The issue has been resolved. Show all issues

Same.

Commit:

55abae0f437b8599684f8ce0b4bdc5ae2f4885c7

41d4ceba302bff90a44861baf27ac0cafc2f2e54

Diff:

Revision 3 (+4 -7)

Show changes

	reviewboard/webapi/resources/review_reply_file_attachment_comment.py
	reviewboard/webapi/resources/validate_diff.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/tests/test_review_request_draft.py

Commit:

41d4ceba302bff90a44861baf27ac0cafc2f2e54

9237d3070790771d95ec6fd3f11f82a82c99cc00

Diff:

Revision 4 (+2 -5)

Show changes

	reviewboard/webapi/resources/validate_diff.py
	reviewboard/webapi/tests/mixins.py
	reviewboard/webapi/tests/test_review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/tests/mixins.py
    reviewboard/webapi/tests/test_review_request_draft.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (7bf9908)