Ensure diff fragments are loaded for discarded and submitted reviews

Review Request #664 — Created Dec. 8, 2008 and submitted

Information

Review Board SVN (deprecated)

Reviewers

Currently, diff fragments only get loaded for pending reviews; the "Loading diff fragment..." spinner just keeps on spinning if you look at a submitted or discarded review.

This is because the diff_comments funcQueue never gets started because the start() call only gets output by the relevant template if the user has edit permissions AND the review is pending.

This change moves the call to funcQueue.start() outside of these conditional blocks, so it works for any user and any review request status.
Tested on our local system with pending, submitted and discarded review requests.
chipx86
  1. Modified slightly to remove redundant <script> tags (we now move the {% if %} blocks above into the first <script>.
    
    Thanks for the change! Committed as r1626.
  2. 
      
Loading...