-
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
Fixed a few PEP-8 issues.
Review Request #6638 — Created Nov. 23, 2014 and submitted
Information | |
---|---|
justy777 | |
Review Board | |
master | |
423f6ef... | |
Reviewers | |
reviewboard, students | |
Since some issues have slipped past ReviewBot (plus there are a lot we never fixed). This change fixes almost everything ouside the modules, with the exception of a few things PEP-8 considers as problems but are actually preferred.
Ran unit tests, and pep8.
Description | From | Last Updated |
---|---|---|
I'd rather not do this. There's no real point in practice. Same for all other asserts on imports. |
|
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
This just makes the code more error-prone and less readable. I'd prefer you undo it. |
|
|
There's a # in the comment now. |
|
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
'PIPELINE_CSS' imported but unused |
![]() |
|
'PIPELINE_JS' imported but unused |
![]() |
|
'django_reset' imported but unused |
![]() |
|
I think the better fix (since this has a character in it) would be to prefix this line with 'r' … |
|
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
'PIPELINE_CSS' imported but unused |
![]() |
|
'PIPELINE_JS' imported but unused |
![]() |
|
'django_reset' imported but unused |
![]() |
|
'from settings_local import *' used; unable to detect undefined names |
![]() |
|
'PIPELINE_CSS' imported but unused |
![]() |
|
'PIPELINE_JS' imported but unused |
![]() |

-
ez_setup.py isn't maintained by us. We should revert all changes to it.
By the way, if you're not already, run ./contrib/internal/run-pyflakes.py instead of just pyflakes.
-
reviewboard/__init__.py (Diff revision 1) I'd rather not do this. There's no real point in practice.
Same for all other asserts on imports.
-
reviewboard/staticbundles.py (Diff revision 1) This just makes the code more error-prone and less readable. I'd prefer you undo it.
-
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Description: |
|
||||||
Testing Done: |
|
||||||
Commit: |
|
||||||
Diff: |
Revision 2 (+11 -9) |

-
Tool: PEP8 Style Checker Processed Files: setup.py reviewboard/settings.py reviewboard/staticbundles.py Tool: Pyflakes Processed Files: setup.py reviewboard/settings.py reviewboard/staticbundles.py
-
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
-
-
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+9 -8) |

-
Tool: Pyflakes Processed Files: setup.py reviewboard/settings.py Tool: PEP8 Style Checker Processed Files: setup.py reviewboard/settings.py
-
-
reviewboard/settings.py (Diff revision 3) 'from settings_local import *' used; unable to detect undefined names
-
-
-
-
reviewboard/settings.py (Diff revision 3) I think the better fix (since this has a character in it) would be to prefix this line with 'r' as well.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+9 -8) |

-
Tool: Pyflakes Processed Files: setup.py reviewboard/settings.py Tool: PEP8 Style Checker Processed Files: setup.py reviewboard/settings.py
-
-
reviewboard/settings.py (Diff revision 4) 'from settings_local import *' used; unable to detect undefined names
-
-