Summary

Fixed a few PEP-8 issues.

Review Request #6638 — Created Nov. 23, 2014 and submitted Nov. 30, 2014, 2:57 p.m.

Information

Owner

justy777

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

423f6ef...

Reviewers

Groups

reviewboard, students

People

Description

Since some issues have slipped past ReviewBot (plus there are a lot we never fixed). This change fixes almost everything ouside the modules, with the exception of a few things PEP-8 considers as problems but are actually preferred.

Testing Done

Ran unit tests, and pep8.

Issues

Description	From	Last Updated
I'd rather not do this. There's no real point in practice. Same for all other asserts on imports.	chipx86	Nov. 24, 2014, 6:26 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Nov. 24, 2014, 5:42 p.m.
This just makes the code more error-prone and less readable. I'd prefer you undo it.	chipx86	Nov. 24, 2014, 6:26 p.m.
There's a # in the comment now.	chipx86	Nov. 24, 2014, 6:33 p.m.
'django_reset' imported but unused	reviewbot	Nov. 24, 2014, 6:41 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Nov. 24, 2014, 6:41 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Nov. 24, 2014, 6:41 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Nov. 24, 2014, 6:41 p.m.
'django_reset' imported but unused	reviewbot	Nov. 24, 2014, 7:41 p.m.
I think the better fix (since this has a character in it) would be to prefix this line with 'r' …	david	Nov. 28, 2014, 11:43 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Nov. 24, 2014, 7:41 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Nov. 24, 2014, 7:41 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Nov. 24, 2014, 7:41 p.m.
'django_reset' imported but unused	reviewbot	Nov. 28, 2014, 11:49 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Nov. 28, 2014, 11:49 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Nov. 28, 2014, 11:49 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Nov. 28, 2014, 11:49 p.m.

Tool: Pyflakes
Processed Files:
    ez_setup.py
    setup.py
    reviewboard/staticbundles.py
    reviewboard/settings.py
    reviewboard/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    ez_setup.py
    setup.py
    reviewboard/staticbundles.py
    reviewboard/settings.py
    reviewboard/__init__.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
1. justy777 Nov. 23, 2014, 11:25 p.m.
  What does this really mean?

ez_setup.py isn't maintained by us. We should revert all changes to it.

By the way, if you're not already, run ./contrib/internal/run-pyflakes.py instead of just pyflakes.

reviewboard/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

I'd rather not do this. There's no real point in practice.

Same for all other asserts on imports.

reviewboard/staticbundles.py (Diff revision 1)

The issue has been resolved. Show all issues

This just makes the code more error-prone and less readable. I'd prefer you undo it.

setup.py (Diff revision 1)
The issue has been resolved. Show all issues
```
There's a # in the comment now.
```

Summary:

-	Fixed a ton of PEP8 issues, and a few Pyflakes issues.
+	Fixed a ton of PEP8 issues.

Description:

~		Since some issues have slipped past ReviewBot (plus there are a lot we never fixed). This change fixes almost everything ouside the modules, with the exception of a few things PEP-8 considers as problems but are actually preferred. Pyflakes also complains about unused imports, the keyword assert is used to confirm that it should be there.
	~	Since some issues have slipped past ReviewBot (plus there are a lot we never fixed). This change fixes almost everything ouside the modules, with the exception of a few things PEP-8 considers as problems but are actually preferred.

Testing Done:

~		Ran unit tests, pep8, and pyflakes.
	~	Ran unit tests, and pep8.

Commit:

-	b611bc8d506ecf4350430f18bb3d5e60556c436b
+	2d4d80b74b121a2b0fa59b79abaf4392355298df

Diff:

Revision 2 (+11 -9)

Show changes

	setup.py
	reviewboard/settings.py
	reviewboard/staticbundles.py

Tool: PEP8 Style Checker
Processed Files:
    setup.py
    reviewboard/settings.py
    reviewboard/staticbundles.py



Tool: Pyflakes
Processed Files:
    setup.py
    reviewboard/settings.py
    reviewboard/staticbundles.py

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Summary:

-	Fixed a ton of PEP8 issues.
+	Fixed a few of PEP8 issues.

Commit:

-	2d4d80b74b121a2b0fa59b79abaf4392355298df
+	e391328bd9a4a3d0e90a0a58064c43c16dfff192

Diff:

Revision 3 (+9 -8)

Show changes

	setup.py
	reviewboard/settings.py

Tool: Pyflakes
Processed Files:
    setup.py
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    setup.py
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Summary:

-	Fixed a few of PEP8 issues.
+	Fixed a few PEP-8 issues.

reviewboard/settings.py (Diff revision 3)

The issue has been resolved. Show all issues

I think the better fix (since this has a character in it) would be to prefix this line with 'r' as well.

Commit:

-	e391328bd9a4a3d0e90a0a58064c43c16dfff192
+	423f6efdac5b450a151179632ff4460993e9e90e

Diff:

Revision 4 (+9 -8)

Show changes

	setup.py
	reviewboard/settings.py

Tool: Pyflakes
Processed Files:
    setup.py
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    setup.py
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (5e0ac9c)