Fix formatting errors in extensions module according to PEP8
Review Request #6631 — Created Nov. 23, 2014 and submitted
| Information | |
|---|---|
| justy777 | |
| Review Board | |
| master | |
| 477e624... | |
| Reviewers | |
| reviewboard, students | |
Fixed the following format errors:
extensions/templatetags/rb_extensions.py:93:80: E501 line too long (82 > 79 characters)
extensions/tests.py:190:26: E126 continuation line over-indented for hanging indent
extensions/tests.py:515:80: E501 line too long (80 > 79 characters)
extensions/tests.py:537:80: E501 line too long (80 > 79 characters)
extensions/tests.py:556:80: E501 line too long (80 > 79 characters)
extensions/tests.py:577:80: E501 line too long (80 > 79 characters)
extensions/tests.py:587:80: E501 line too long (88 > 79 characters)
Ran unit tests for diffviewer module, and ran pep8 again.
| Description | From | Last Updated |
|---|---|---|
|
Can you keep it how it was, but put context on the following line? |
 chipx86
|
|
|
The original way was correct. To keep the error from occurring, try: self.assertEqual( t.render(...), '<li>...</li>' % { ... }) That … |
chipx86
|
|
|
This is now less readable. Maybe put the space before the 'test_should_render'? |
chipx86
|
-
-
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1) Can you keep it how it was, but put
contexton the following line? -
reviewboard/extensions/tests.py (Diff revision 1) The original way was correct.
To keep the error from occurring, try:
self.assertEqual( t.render(...), '<li>...</li>' % { ... })That way, indentation is a multiple of 4, satisfying pep8.
-
reviewboard/extensions/tests.py (Diff revision 1) This is now less readable.
Maybe put the space before the
'test_should_render'?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+18 -11) |
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/tests.py Tool: Pyflakes Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/tests.py