Fix formatting errors in extensions module according to PEP8

Review Request #6631 — Created Nov. 23, 2014 and submitted

justy777
Review Board
master
477e624...
reviewboard, students

Fixed the following format errors:
extensions/templatetags/rb_extensions.py:93:80: E501 line too long (82 > 79 characters)
extensions/tests.py:190:26: E126 continuation line over-indented for hanging indent
extensions/tests.py:515:80: E501 line too long (80 > 79 characters)
extensions/tests.py:537:80: E501 line too long (80 > 79 characters)
extensions/tests.py:556:80: E501 line too long (80 > 79 characters)
extensions/tests.py:577:80: E501 line too long (80 > 79 characters)
extensions/tests.py:587:80: E501 line too long (88 > 79 characters)

Ran unit tests for diffviewer module, and ran pep8 again.

Description From Last Updated

Can you keep it how it was, but put context on the following line?

chipx86chipx86

The original way was correct. To keep the error from occurring, try: self.assertEqual( t.render(...), '<li>...</li>' % { ... }) That ...

chipx86chipx86

This is now less readable. Maybe put the space before the 'test_should_render'?

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
chipx86
  1. 
      
  2. Can you keep it how it was, but put context on the following line?

  3. reviewboard/extensions/tests.py (Diff revision 1)
     
     
     
     

    The original way was correct.

    To keep the error from occurring, try:

    self.assertEqual(
        t.render(...),
        '<li>...</li>' % {
            ...
        })
    

    That way, indentation is a multiple of 4, satisfying pep8.

  4. reviewboard/extensions/tests.py (Diff revision 1)
     
     
     

    This is now less readable.

    Maybe put the space before the 'test_should_render'?

  5. 
      
justy777
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/extensions/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/extensions/tests.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
justy777
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (4501244)
Loading...