Summary

Add user-friendly string conversion for Review Request's status.

Review Request #6620 — Created Nov. 22, 2014 and discarded Nov. 27, 2014, 7:53 a.m.

Information

Owner

mloyzer

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add easy conversion from a Review Request's status code to a user-friendly version

Testing Done

Tested each status type and returned correct result.

Issues

Description	From	Last Updated
We already have this information in ReviewRequest.STATUSES	david	Nov. 24, 2014, 1:38 p.m.

Status:: Discarded

Status:: Re-opened
Summary:: Add user-friendly string conversion for Review Request's status.
Description:: +
Add easy conversion from a Review Request's status code to a user-friendly version
Testing Done:: +
Tested each status type and returned correct result.
Branch:: master
Commit:: 7a5e5a5fd6189fdd073629d465af91fef3d992ed
Groups:: reviewboard
Diff:: Revision 1 (+11)

reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/review_request.py

Fix it!

reviewboard/reviews/models/review_request.py (Diff revision 1)

An issue was opened. Show all issues

We already have this information in ReviewRequest.STATUSES

mloyzer

Nov. 25, 2014, 5:20 p.m.

So what is the best way to retrieve the nice string? iterate through STATUSES until you find the proper code?

david

Nov. 25, 2014, 5:24 p.m.

It looks like django already provides a method to do that. Give review_request.get_status_display() a try.

Status:: Discarded
Change Summary:: Django offers a method that does the same.