Drag 'n Drop Inline Images Backend - Form

Review Request #6615 — Created Nov. 21, 2014 and submitted

dkus
Review Board
master
reviewboard, students

Part of a set of changes to add support for dragging and dropping images into the markdown editor.

Adding a form to create FileAttachments owned by a user. Moving the mimetype processing stuff to the mimetypes.py file. Adding tests around FileAttachments owned by users.

All unit tests pass after making the changes.

Added unit tests around the changes to the FileAttachment model:
- Tests around creating a FileAttachment with/without a file
- Tests around the is_accessible_by(user) and is_mutable_by(user) methods

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/attachments/tests.py
        reviewboard/attachments/mimetypes.py
        reviewboard/attachments/forms.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/attachments/tests.py
        reviewboard/attachments/mimetypes.py
        reviewboard/attachments/forms.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
dkus
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to ucosp/dkus/dnd-inline-images (eda73e1)
Loading...