Use six.moves for urllib changes
Review Request #6604 — Created Nov. 18, 2014 and submitted
This changes our code to use the six.moves adapters for calls into
urllib/urllib2/urlparse. This makes it so that we can run the same code on both
python 2 and 3.
- Ran unit tests.
- Checked that rbt post still worked.
Description | From | Last Updated |
---|---|---|
Blank line between these. |
chipx86 | |
We should check with Steven, but Request may be considered public API. To be safe, let's keep the original name, … |
chipx86 | |
Blank line before the six imports. |
chipx86 | |
Blank line above this. |
chipx86 | |
This should be in the third-party import group. |
chipx86 | |
Blank line before this. |
chipx86 |
-
-
-
rbtools/api/request.py (Diff revision 1) We should check with Steven, but
Request
may be considered public API.To be safe, let's keep the original name, and instead import
Request as URLRequest
or something. -
-
-
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+51 -37) |
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py rbtools/api/request.py rbtools/clients/mercurial.py rbtools/api/resource.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py rbtools/api/request.py rbtools/clients/mercurial.py rbtools/api/resource.py rbtools/commands/__init__.py
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+52 -37) |
-
Tool: Pyflakes Processed Files: rbtools/clients/svn.py rbtools/api/request.py rbtools/clients/mercurial.py rbtools/api/resource.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/svn.py rbtools/api/request.py rbtools/clients/mercurial.py rbtools/api/resource.py rbtools/commands/__init__.py