Use six.moves for urllib changes

Review Request #6604 — Created Nov. 18, 2014 and submitted

david
RBTools
master
524664a...
rbtools

This changes our code to use the six.moves adapters for calls into
urllib/urllib2/urlparse. This makes it so that we can run the same code on both
python 2 and 3.

  • Ran unit tests.
  • Checked that rbt post still worked.
Description From Last Updated

Blank line between these.

chipx86chipx86

We should check with Steven, but Request may be considered public API. To be safe, let's keep the original name, …

chipx86chipx86

Blank line before the six imports.

chipx86chipx86

Blank line above this.

chipx86chipx86

This should be in the third-party import group.

chipx86chipx86

Blank line before this.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/api/request.py
        rbtools/clients/mercurial.py
        rbtools/api/resource.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/api/request.py
        rbtools/clients/mercurial.py
        rbtools/api/resource.py
        rbtools/commands/__init__.py
    
    
  2. 
      
chipx86
  1. 
      
  2. rbtools/api/request.py (Diff revision 1)
     
     
     

    Blank line between these.

  3. rbtools/api/request.py (Diff revision 1)
     
     

    We should check with Steven, but Request may be considered public API.

    To be safe, let's keep the original name, and instead import Request as URLRequest or something.

  4. rbtools/api/resource.py (Diff revision 1)
     
     
     
     

    Blank line before the six imports.

    1. Looks like this didn't end up in the final commit.

  5. rbtools/clients/mercurial.py (Diff revision 1)
     
     

    Blank line above this.

  6. rbtools/clients/svn.py (Diff revision 1)
     
     

    This should be in the third-party import group.

  7. rbtools/commands/__init__.py (Diff revision 1)
     
     

    Blank line before this.

  8. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/api/request.py
        rbtools/clients/mercurial.py
        rbtools/api/resource.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/api/request.py
        rbtools/clients/mercurial.py
        rbtools/api/resource.py
        rbtools/commands/__init__.py
    
    
  2. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/svn.py
        rbtools/api/request.py
        rbtools/clients/mercurial.py
        rbtools/api/resource.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/svn.py
        rbtools/api/request.py
        rbtools/clients/mercurial.py
        rbtools/api/resource.py
        rbtools/commands/__init__.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (9ef53f9)
Loading...