Summary

Use six.moves for urllib changes

Review Request #6604 — Created Nov. 18, 2014 and submitted Nov. 19, 2014, 1:03 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

524664a...

Reviewers

Groups

rbtools

People

Description

This changes our code to use the six.moves adapters for calls into
urllib/urllib2/urlparse. This makes it so that we can run the same code on both
python 2 and 3.

Testing Done


Ran unit tests.
Checked that rbt post still worked.

Issues

Description	From	Last Updated
Blank line between these.	chipx86	Nov. 18, 2014, 11:54 p.m.
We should check with Steven, but Request may be considered public API. To be safe, let's keep the original name, …	chipx86	Nov. 18, 2014, 11:55 p.m.
Blank line before the six imports.	chipx86	Nov. 19, 2014, 12:59 a.m.
Blank line above this.	chipx86	Nov. 18, 2014, 11:55 p.m.
This should be in the third-party import group.	chipx86	Nov. 18, 2014, 11:56 p.m.
Blank line before this.	chipx86	Nov. 18, 2014, 11:56 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/api/request.py
    rbtools/clients/mercurial.py
    rbtools/api/resource.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/api/request.py
    rbtools/clients/mercurial.py
    rbtools/api/resource.py
    rbtools/commands/__init__.py

rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

rbtools/api/request.py (Diff revision 1)

The issue has been resolved. Show all issues

We should check with Steven, but Request may be considered public API.
To be safe, let's keep the original name, and instead import Request as URLRequest or something.

rbtools/api/resource.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before the six imports.
```
1. chipx86 Nov. 19, 2014, 12:42 a.m.
  Looks like this didn't end up in the final commit.
rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line above this.
```
rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be in the third-party import group.
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before this.
```

Commit:

02a55ff6ea5b96df5c21c77dda7b7db78b86a96f

19bf64455f1b4454f0d0e56ac5f486f6fdc69736

Diff:

Revision 2 (+51 -37)

Show changes

	rbtools/api/request.py
	rbtools/api/resource.py
	rbtools/clients/mercurial.py
	rbtools/clients/svn.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/api/request.py
    rbtools/clients/mercurial.py
    rbtools/api/resource.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/api/request.py
    rbtools/clients/mercurial.py
    rbtools/api/resource.py
    rbtools/commands/__init__.py

Commit:

19bf64455f1b4454f0d0e56ac5f486f6fdc69736

524664a0dfa50b913ce0b02f3e416a475b8cfa1e

Diff:

Revision 3 (+52 -37)

Show changes

	rbtools/api/request.py
	rbtools/api/resource.py
	rbtools/clients/mercurial.py
	rbtools/clients/svn.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/svn.py
    rbtools/api/request.py
    rbtools/clients/mercurial.py
    rbtools/api/resource.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/svn.py
    rbtools/api/request.py
    rbtools/clients/mercurial.py
    rbtools/api/resource.py
    rbtools/commands/__init__.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (9ef53f9)