Don't attempt a doomed request when publishing review replies.

Review Request #6603 — Created Nov. 18, 2014 and submitted

Information

Review Board
release-2.0.x
c95f459...

Reviewers

When publishing review replies, we'd attempt to reset the state. Part
of this operation was discarding the reply if empty. However, in the
case of publishing, we've just set up a new reply and know we don't have
a reply sitting around to reset.

We now simply skip this step if publishing.

This also fixes the banner persisting on the screen if discarding twice
in a row.

Tested replying to comments and reviews.

Tested publishing replies.

Tested discarding multiple times without problems.

Unit tests pass.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/models/reviewReplyEditorModel.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/models/reviewReplyEditorModel.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (da00d22)
Loading...