Pass the extension instance to SignalHook-registered signal callbacks.

Review Request #6602 — Created Nov. 17, 2014 and submitted

Information

Djblets
release-0.8.x
4303cca...

Reviewers

When using SignalHook, the callback will now be passed an extension
instance as a keyword argument, making it easier to operate on the
extension or access settings without having to fetch the instance.

Due to the changes being made here, I've also changed sandbox behavior
so that we always log the error, even if we're not sandboxing.

Unit tests pass.

Used this to get the extension instance.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/extensions/hooks.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/extensions/hooks.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (c4fe0fc)
Loading...