Fix loading review public states and resolving comment issues.

Review Request #6601 — Created Nov. 17, 2014 and submitted

Information

Review Board
release-2.0.x
b26cafe...

Reviewers

We were deserializing the 'public' state of reviews and replies
incorrectly, which led to problems when operating on any child
resources. One affected set of resources were the comment resources,
which became clearly broken when trying to resolve issues.

Once fixed, I noticed that, like the review dialog, closing an issue
would take the HTML-formatted text originally fetched and send that in
the request. We only need to send issueStatus, and don't want to
override the comment, so we now set an appropriate attrs option.

Properly closed comments, and saw that they didn't pollute the text stored
in the database.

Unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/models/commentIssueManagerModel.js
        reviewboard/static/rb/js/resources/models/reviewModel.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/models/commentIssueManagerModel.js
        reviewboard/static/rb/js/resources/models/reviewModel.js
        reviewboard/static/rb/js/resources/models/reviewReplyModel.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (43aff31)
Loading...