Allow Hosting Service Integration through ReviewBoard Extensions
Review Request #6572 — Created Nov. 9, 2014 and submitted
There's now a HostingServiceHook that extensions can use to register hosting services. This handles registering, unregistering, and retriving the hosting sevices.
Unit test have been written to make sure that HostingService subclasses are registered and unregistered properly.
Summary: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||
Testing Done: |
|
||||||||||||||||||
Commit: |
|
||||||||||||||||||
Diff: |
Revision 2 (+52) |

-
Tool: Pyflakes Processed Files: reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/hooks.py reviewboard/extensions/tests.py
Description: |
|
---|
-
-
reviewboard/extensions/tests.py (Diff revision 2) This test doesn't assert anything, so what is it testing? If you are expecting something to not throw an exception, you should do something like
try: something_that_might_raise() except SomeException as e: self.fail("Raised SomeException!")
Same for
test_unregister
.
-
-
reviewboard/extensions/tests.py (Diff revision 2) Like my response about
test_register
, this test should check that the hosting service is no longer registered.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+54) |