• 
      

    [rbslack] Fix escaping of review request summaries.

    Review Request #6570 — Created Nov. 8, 2014 and submitted

    Information

    rb-extension-pack
    84bc05a...

    Reviewers

    We were using Django's escape() for review request summaries, which
    covers a variety of characters. However, Slack expects that only &, <
    and > will ever be escaped, and will show any other entities as-is.

    This change adds our own escaping logic in order to not leak entities in
    the summaries.

    Posted a change with a variety of things that Django would escape. All
    characters looked fine in the link.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbslack/rbslack/extension.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbslack/rbslack/extension.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (f181da8)