Only show diff expansion links in review comments.

Review Request #6567 - Created Nov. 7, 2014 and submitted

Barret Rennie
Review Board
master
36d630f...
reviewboard, students

Add the show_controls parameter to build_diff_fragments which
determines if expansion controls should be shown for the diff
fragments. This parameter defaults to False.

The comment_diff_fragments view sets this show_controls parameter
to True if and only if it is showing the fragments in a review and
not the edit review dialog.

Tested on local server:

  • Review comments contain expansion links.
  • Edit review dialog does not contain expansion links.
  • Emails do not contain expansion links.
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
    
    
  2. 
      
Barret Rennie
David Trowbridge
  1. Ship It!

  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (36c54ba)
Loading...