Bullet-proof change descriptions with deleted file attachments.
Review Request #6563 — Created Nov. 6, 2014 and submitted
Because of the ways that file attachments and change descriptions are stored,
it's possible to delete a file attachment from the database but still have its
old pk referenced from the change description. In this case, trying to render
that change description would crash because it no longer exists.This change adds some bullet-proofing to ensure that we don't show a traceback.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
In this particular failure case we're dealing with, it's now sounding more like the file exists but is no longer … |
 chipx86
|
-
-
reviewboard/reviews/builtin_fields.py (Diff revision 1) In this particular failure case we're dealing with, it's now sounding more like the file exists but is no longer associated with the review request in any way. Can we have this conditionally check for the value in the map, and if it's missing, attempt a query for that object, then skip only if that doesn't exist?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+16 -6) |
Tool: Pyflakes Processed Files: reviewboard/reviews/builtin_fields.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/builtin_fields.py