Update the new review dialog for the Markdown changes
Review Request #6555 — Created Nov. 4, 2014 and submitted
All the Markdown changes are getting ready to land in release-2.0.x, and will then be
merged into master. However, given the extensive changes to the new review dialog, merging
that code is non-trivial, and required a fair amount of work.
This change covers all the changes going into the review dialog, including those previously
reviewed from the markdown-redesign branch.
The big highlights are that we now include both Markdown and raw text when fetching payloads,
we parse the text fields from the correct place depending on the user's defaultUseRichText
setting, and we work properly with the inline editors.
All unit tests pass.
I played with the review dialog a bit, testing body and comment fields, and loading/saving
in both plain text and Markdown formats. I also tested with different user defaults.
I saw that comments always rendered as HTML properly. When I went to edit, Markdown would
always show in Markdown mode, using CodeMirror. If my user Markdown default was set, plain
text would be escaped. Otherwise, unescaped.
When saving, I saw that the new text was rendered properly, and the escaped/unescaped content
was properly set when editing.
I also checked the data going out to the API and the data coming back.