Making call to DnsRequest more explicit.

Review Request #6552 — Created Nov. 3, 2014 and submitted

Information

Review Board
master
deea8b2...

Reviewers

Use DNS native Type for qtype when calling DnsRequest()

On a poorly configured apache, it seems the unicode literal that we pass as qtype doesn't get
converted correctly. This saves the internal DNS code from having to do the conversion from
string to int and is more robust against poorly configured apache mod_wsgi setups.


 
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/backends.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/backends.py
    
    
  2. 
      
EL
david
  1. Ship It!

  2. 
      
EL
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (ab45ebf)
Loading...