Factor in the Markdown pref into the review request ETag.

Review Request #6550 — Created Nov. 2, 2014 and submitted

Information

Review Board
release-2.0.x
be595f8...

Reviewers

The Markdown pref affects the rendering of the review request page,
requiring that we factor it in for the ETag so that the wrong data isn't
cached after changing the preference.

Saw that the pref was being factored into the resulting ETag.

Description From Last Updated

list comprehension redefines 'file_attachment' from line 580

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/markdown_utils.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/markdown_utils.py
    
    
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Show all issues
     list comprehension redefines 'file_attachment' from line 580
    
  3. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to markdown-redesign (bd829f7)
Loading...