Fix issues with raw values passed to the page.

Review Request #6548 — Created Nov. 1, 2014 and submitted

Information

Review Board
release-2.0.x
994f9d5...

Reviewers

When storing data attributes for raw values for custom fields that
weren't yet set, we'd end up setting the value to "None," which would
appear when editing the field. This was clearly wrong. We now make sure
to use an empty string in this case.

For built-in fields, we were setting the data attributes for raw values
unnecessarily. We already have that state separately, so setting the
data attributes just led to wasted memory and bandwidth. We now make
sure not to send those along.

Edited a custom field on a new review request. Saw an empty field instead
of "None".

Viewed the source of a review request page and didn't see any data attributes
for built-in fields, only custom fields.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/markdown_utils.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/markdown_utils.py
    
    
  2. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/markdown_utils.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
        reviewboard/reviews/markdown_utils.py
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to markdown-redesign (8a4ef0f)
Loading...