Fix some state and interactivity issues with TextEditorView.
Review Request #6541 — Created Oct. 30, 2014 and submitted
When canceling the editor, the Markdown checkbox wouldn't revert to the
original state. Toggling the Markdown state also failed to mark the
editor as dirty or emit a change signal.These have been fixed, and unit tests added.
Canceled and saw the checkbox reset.
Toggled the checkbox and saved. Saw a request go out.
Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
I think this might be more obvious as: return this._editor && (this._richTextDirty || this._editor.isDirty(initialValue)); |
 david
|
-
-
reviewboard/static/rb/js/ui/views/textEditorView.js (Diff revision 1) I think this might be more obvious as:
return this._editor && (this._richTextDirty || this._editor.isDirty(initialValue));
Change Summary:
Clean up the logic for isDirty.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+65 -17) |
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js