Don't fail when using --diff-filename=- and credentials on the command line.

Review Request #6538 — Created Oct. 30, 2014 and submitted

Information

RBTools
release-0.6.x
dd155eb...

Reviewers

When passing a diff in on stdin, we can't also prompt for credentials.
Unfortunately, the check for this was also making it so that it would fail
even in the case where credentails were passed in on the command-line. Moving
the check fixes the problem.

  • Smoke tested --diff-filename.
  • Ran unit tests.
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/__init__.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (77da95b)
Loading...