Re factoring the alphabetic paginator changed.

Review Request #6522 — Created Oct. 28, 2014 and submitted

rmdone
Review Board
master
829
6521, 6368, 6369
6521
35f681d...
reviewboard, students

reverting grids.py userDataGrid back to original behaviour, but now making it a subclass of the newly added AlphanumericDataGrid (which provides alphabetic pagination)

Unit tests all pass
All button cases manually tested. (Forward, back, first and last arrows, each letter).
Verified that changes to not affect any other module that inherits from datagrid (such as the groups list, or the all review requests list, the current 'master' of reviewboard with no changes to the userGrid).

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/grids.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/grids.py
    
    
  2. 
      
RM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/grids.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/grids.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
RM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (4f209bc)
Loading...