Re factoring the alphabetic paginator changed.
Review Request #6522 — Created Oct. 28, 2014 and submitted
reverting grids.py userDataGrid back to original behaviour, but now making it a subclass of the newly added AlphanumericDataGrid (which provides alphabetic pagination)
Unit tests all pass
All button cases manually tested. (Forward, back, first and last arrows, each letter).
Verified that changes to not affect any other module that inherits from datagrid (such as the groups list, or the all review requests list, the current 'master' of reviewboard with no changes to the userGrid).
RM
- Change Summary:
-
Added use of extra_regex parameter, which is responsible for telling to parent class what qualifies for the "everything else" button (0)
- Commit:
-
5afd9a720c62f4608ee84bf8cf94dcb2405cd03435f681d1f1054766bea754be76c1725b107ee1fb
- Diff:
-
Revision 2 (+5 -13)
Tool: Pyflakes Processed Files: reviewboard/datagrids/grids.py Tool: PEP8 Style Checker Processed Files: reviewboard/datagrids/grids.py