-
-
-
trunk/reviewboard/admin/forms.py (Diff revision 1) This should be in title casing instead of sentence casing.
-
trunk/reviewboard/admin/forms.py (Diff revision 1) It seems really weird to say "Or ..." here. It would be especially confusing to translators. This should really stand alone. You may want to instead say how this takes precedence over the e-mail domain if available. Is the mail attribute standardized and available in all LDAP configs? If so, we may as well hard-code it. I honestly don't know enough about LDAP.
Support LDAP email attribute
Review Request #652 — Created Nov. 30, 2008 and submitted
| Information | |
|---|---|
| eph | |
| Review Board SVN (deprecated) | |
| Reviewers | |
| reviewboard | |
This is small patch which allows to specify LDAP attribute containing user's e-mail address instead of creating one as username@domain. Just bear in mind that I never programmed in python and I just did this to be able to use RB at work :). I also tried to tidy it up a little bit (mainly the settings form) but failed.
-
-
trunk/reviewboard/accounts/backends.py (Diff revision 2) I don't even think Python will accept this... Or the indentation on the next line. There's the extra colon, and the next line doesn't match the indentation of the rest.
-
trunk/reviewboard/admin/forms.py (Diff revision 2) Make sure this wraps to ~76 characters or so. It must stay under 80. Also, "E-mail" in this one and the next.