Fix file attachment updating.

Review Request #6511 — Created Oct. 26, 2014 and submitted — Latest diff uploaded

Information

Review Board
master
5890653...

Reviewers

When I pushed these changes, I had made a couple last-minute changes that
didn't end up completely committed to git, which meant that things were in a
relatively broken state. This change fixes two issues with file attachment
histories.

First, the attribute name when creating new file attachments had changed from
attachment_history_id to attachment_history. This was reflected in most
places but a couple didn't get the update.

Second, newly-created FileAttachmentHistory objects weren't being properly
associated with the right review request, which meant that future updates would
be rejected.

  • Created some new file attachments and then updated them.
  • Ran unit tests