Fix file attachment updating.
Review Request #6511 — Created Oct. 26, 2014 and submitted
When I pushed these changes, I had made a couple last-minute changes that
didn't end up completely committed to git, which meant that things were in a
relatively broken state. This change fixes two issues with file attachment
histories.First, the attribute name when creating new file attachments had changed from
attachment_history_id
toattachment_history
. This was reflected in most
places but a couple didn't get the update.Second, newly-created
FileAttachmentHistor
y objects weren't being properly
associated with the right review request, which meant that future updates would
be rejected.
- Created some new file attachments and then updated them.
- Ran unit tests
-
-
reviewboard/reviews/models/base_review_request_details.py (Diff revision 1) I didn't notice this before, but why isn't this just set above in the create call?
-
-
reviewboard/attachments/forms.py (Diff revision 1) Yeah this is what I was imagining was necesarry to fix my problem.