Summary

Fix file attachment updating.

Review Request #6511 — Created Oct. 26, 2014 and submitted Oct. 26, 2014, 10:37 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

5890653...

Reviewers

Groups

reviewboard

People

Description

When I pushed these changes, I had made a couple last-minute changes that
didn't end up completely committed to git, which meant that things were in a
relatively broken state. This change fixes two issues with file attachment
histories.

First, the attribute name when creating new file attachments had changed from
attachment_history_id to attachment_history. This was reflected in most
places but a couple didn't get the update.

Second, newly-created FileAttachmentHistory objects weren't being properly
associated with the right review request, which meant that future updates would
be rejected.

Testing Done


Created some new file attachments and then updated them.
Ran unit tests

Issues

Description	From	Last Updated
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 26, 2014, 10:27 p.m.
I didn't notice this before, but why isn't this just set above in the create call?	chipx86	Oct. 26, 2014, 10:31 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/base_review_request_details.py
    reviewboard/attachments/forms.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileAttachmentModel.js
    reviewboard/static/rb/js/views/uploadAttachmentView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/base_review_request_details.py
    reviewboard/attachments/forms.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/fileAttachmentModel.js
    reviewboard/static/rb/js/views/uploadAttachmentView.js

reviewboard/attachments/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

reviewboard/reviews/models/base_review_request_details.py (Diff revision 1)

The issue has been dropped. Show all issues

I didn't notice this before, but why isn't this just set above in the create call?

david Oct. 26, 2014, 10:31 p.m.

ManyToMany relations can't be set in create()

chipx86 Oct. 26, 2014, 10:31 p.m.
```
attachment_history is a ForeignKey.
```

david Oct. 26, 2014, 10:34 p.m.

But the file_attachment isn't the thing being created, and you also can't set the many side of a foreign key in create()

chipx86 Oct. 26, 2014, 10:35 p.m.

Oops, we're creating a History. Read that wrong, sorry!

reviewboard/attachments/forms.py (Diff revision 1)

Yeah this is what I was imagining was necesarry to fix my problem.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (baf3b8a)