Add API caching support to rbtools.

Review Request #6504 — Created Oct. 24, 2014 and submitted

brennie
RBTools
master
6608, 6584
89b50a0...
rbtools, students

Add the rbtools.api.cache module. This module includes the
APICache class, which allows the results of HTTP GET requests to
be cached locally to achieve faster lookup. The APICache understands
the following headers:

  • Cache-Control
  • Pragma
  • Vary
  • Last-Modified
  • ETag
  • Expires

The APICache is backed by a SQLite database in the user's cache
directory. If the cache cannot be accessed, the APICache will pass
all requests to the specified urlopen (defaulting to
urllib2.urlopen) method.

The APICache allows for a custom urlopen function so that it can
be tested without making actual HTTP requests.

The APICache stores the version of its schema in the database. If
the APICache is instantiated and the versions of the schema in the
class doesn't match the version of the schema in the database, then
the current cache will be invalidted and the schema will be updated.

Add the ActiveState appdirs module (at version 1.4.0) as
rbtools.utils.appdirs. This module is used to find the user cache
directory in platform-dependant ways.

Add the rbtools.api.cache.Response class which emulates the
behaviour of a urllib2 response. This class allows the read
method to be called more than once.

Add the rbtools.api.cache.CachedResponse class, which is the result
of a cach entry being found the the APICache. It also emulates the
behaviour of a urllib2 response.

Add the clear-cache command. This command manually clears the API
cache.

Added unit tests for the APICache.

Unit tests pass.

The following commands were tested and were successful:

  • rbt status
  • rbt post
  • rbt diff
  • rbt patch
  • rbt close
  • rbt clear-cache

Upon clearing the cache with clear-cache, a new cache is created.
The first run of a command always creates cache entries (where
appropriate, i.e., not for PUT or POST requests).

The /api/ endpoint is successfully cached and the cached version is
used.

When using the patch command for the second time on the same review
request, if the diff has not been updated, then the cached version of
the /api/review-requests/<id>/diff/<diff_revision>/ endpoint is
used.

This review request was posted with the APICache enabled.

Description From Last Updated

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 34 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 13 E303 too many blank lines (3)

reviewbotreviewbot

Col: 9 E303 too many blank lines (2)

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 80 E501 line too long (88 > 79 characters)

reviewbotreviewbot

Col: 32 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 1 W391 blank line at end of file

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

local variable 'kernel' is assigned to but never used

reviewbotreviewbot

undefined name 'kernal'

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 9 E303 too many blank lines (2)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 23 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Switch these two. (cle before clo)

daviddavid

I know that this module is part of the standard library, but is it always guaranteed to work? I don't ...

daviddavid

Since this will be going into master, and we're bumping the minimum python version, you can change this to just ...

daviddavid

except OSError as e:

daviddavid

This can go away.

daviddavid

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Can you alphabetize this list?

daviddavid

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

These should each be using the :file: markup. (I know we don't have that above, but we should there as ...

chipx86chipx86

We should maybe say the HTTP cache for the API.

chipx86chipx86

This and the doc page should match the command: clear-cache

chipx86chipx86

We can just import os.

chipx86chipx86

This isn't part of Python, so it must go in import group #2.

chipx86chipx86

This is a Python standard library module, so it can go in the group above.

chipx86chipx86

What's the reason for setting __slots__ here? Generally speaking, there's rarely a reason to actually set this. It can be ...

chipx86chipx86

The function name and docstring sort of contradict each other.

chipx86chipx86

Might be worth mentioning that this is intended to be API-compatible with a urllib2's response object. Same with CachedResponse below. ...

chipx86chipx86

Can this be a @staticmethod on ApiCache?

chipx86chipx86

Trailing period at the end of the log message. Variable on the next line.

chipx86chipx86

No blank line here.

chipx86chipx86

These could result in exceptions as well, right? Anything we should be catching here? Also, you could skip doing this ...

chipx86chipx86

No blank line here.

chipx86chipx86

Unless we're explicitly needing to worry about the difference between None, empty strings, 0, etc., it's usually best to just ...

chipx86chipx86

No blank line.

chipx86chipx86

In this particular case, it's fine to use \ instead of parens for line continuation.

chipx86chipx86

No blank line.

chipx86chipx86

"cacheable"

chipx86chipx86

No blank line.

chipx86chipx86

We return response in all of these cases. We should probably just do a single return response at the end. ...

chipx86chipx86

Must be on one line. Doc generators will chop it off otherwise.

chipx86chipx86

I read this incorrectly at first. Can you add a small comment saying that we restore the old value below? ...

chipx86chipx86

Blank line between these.

chipx86chipx86

expires can be a separate parameter.

chipx86chipx86

How about "The C locale is not available on this system. The 'Expires' header cannot be parsed."

chipx86chipx86

We should actually grab the old locale and set it, instead of calling resetlocale, in case the caller has actually ...

chipx86chipx86

No blank line before elif and else. Same below.

chipx86chipx86

"posterity's"

chipx86chipx86

Should be on the same line. I'd rather not do the map/strip trick inline like this, and like the one ...

chipx86chipx86

We don't need to check against None unless there's a reason to worry about empty strings and zero. I believe ...

chipx86chipx86

We should probably catch errors for all these commands.

chipx86chipx86

Missing a trailing period.

chipx86chipx86

No blank line here.

chipx86chipx86

We use dumps to serialize, but are loading above with a custom split. dumps may be too heavy. Can we ...

chipx86chipx86

"ensures"

chipx86chipx86

Swap these.

chipx86chipx86

Missing a docstring.

chipx86chipx86

How about "Deletes the HTTP cache used for the API."

chipx86chipx86

Rather than this, how about a method on ApiCache for deleting the cache?

chipx86chipx86

Parameters should go on the line after the log message.

chipx86chipx86

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 13 E303 too many blank lines (2)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Should go up before logging.

chipx86chipx86

This blank line should be removed.

chipx86chipx86

""" on the next line.

chipx86chipx86

Instead of terminating the process, can we just not cache? RBTools is often run in places where it's locked down ...

chipx86chipx86

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'urlopen' imported but unused

reviewbotreviewbot

undefined name 'urllib2'

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'urlopen' imported but unused

reviewbotreviewbot

undefined name 'urllib2'

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Should catch sqlite3.Error here and die gracefully.

brenniebrennie

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

For consistency with the RB database, mind if we use cache_info?

chipx86chipx86

And api_cache.

chipx86chipx86

"URL"

chipx86chipx86

"URL"

chipx86chipx86

"If-None-Match"

chipx86chipx86

No blank line.

chipx86chipx86

No blank line.

chipx86chipx86

These are only available in Python 2.7+.

chipx86chipx86

"API"

chipx86chipx86

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 42.
  2. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  3. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 34
     E128 continuation line under-indented for visual indent
    
  4. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 5
     E303 too many blank lines (2)
    
  5. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 13
     E303 too many blank lines (3)
    
  6. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 9
     E303 too many blank lines (2)
    
  7. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 5
     E303 too many blank lines (2)
    
  8. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (88 > 79 characters)
    
  9. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 32
     E261 at least two spaces before inline comment
    
  10. rbtools/api/cache.py (Diff revision 1)
     
     
    Col: 5
     E303 too many blank lines (2)
    
  11. rbtools/api/request.py (Diff revision 1)
     
     
    Col: 1
     W391 blank line at end of file
    
  12. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (96 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (93 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 38
     E261 at least two spaces before inline comment
    
  15. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 36
     E261 at least two spaces before inline comment
    
  16. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 10
     E261 at least two spaces before inline comment
    
  17. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  18. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (107 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (122 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (87 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  32. rbtools/utils/appdirs.py (Diff revision 1)
     
     
     local variable 'kernel' is assigned to but never used
    
  33. rbtools/utils/appdirs.py (Diff revision 1)
     
     
     undefined name 'kernal'
    
  34. rbtools/utils/appdirs.py (Diff revision 1)
     
     
     'win32com' imported but unused
    
  35. rbtools/utils/appdirs.py (Diff revision 1)
     
     
     'windll' imported but unused
    
  36. rbtools/utils/appdirs.py (Diff revision 1)
     
     
     'com' imported but unused
    
  37. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 2)
     
     
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 2)
     
     
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 2)
     
     
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 35.
  2. rbtools/api/cache.py (Diff revision 3)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. rbtools/api/cache.py (Diff revision 3)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  4. rbtools/api/cache.py (Diff revision 3)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  5. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (96 > 79 characters)
    
  6. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (93 > 79 characters)
    
  7. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 38
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 36
     E261 at least two spaces before inline comment
    
  9. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 10
     E261 at least two spaces before inline comment
    
  10. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  11. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (107 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (122 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (87 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (116 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (115 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  32. rbtools/utils/appdirs.py (Diff revision 3)
     
     
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 3)
     
     
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 3)
     
     
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)