Summary

Add API caching support to rbtools.

Review Request #6504 — Created Oct. 24, 2014 and submitted Nov. 23, 2014, 1:55 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

~~6608~~, ~~6584~~

Commit

89b50a0...

Reviewers

Groups

rbtools, students

People

Description

Add the rbtools.api.cache module. This module includes the

APICache class, which allows the results of HTTP GET requests to

be cached locally to achieve faster lookup. The APICache understands

the following headers:

Cache-Control
Pragma
Vary
Last-Modified
ETag
Expires

The APICache is backed by a SQLite database in the user's cache

directory. If the cache cannot be accessed, the APICache will pass

all requests to the specified urlopen (defaulting to

urllib2.urlopen) method.
The APICache allows for a custom urlopen function so that it can

be tested without making actual HTTP requests.
The APICache stores the version of its schema in the database. If

the APICache is instantiated and the versions of the schema in the

class doesn't match the version of the schema in the database, then

the current cache will be invalidted and the schema will be updated.
Add the ActiveState appdirs module (at version 1.4.0) as

rbtools.utils.appdirs. This module is used to find the user cache

directory in platform-dependant ways.
Add the rbtools.api.cache.Response class which emulates the

behaviour of a urllib2 response. This class allows the read

method to be called more than once.
Add the rbtools.api.cache.CachedResponse class, which is the result

of a cach entry being found the the APICache. It also emulates the

behaviour of a urllib2 response.
Add the clear-cache command. This command manually clears the API

cache.
Added unit tests for the APICache.

Testing Done

Unit tests pass.

The following commands were tested and were successful:

rbt status
rbt post
rbt diff
rbt patch
rbt close
rbt clear-cache

Upon clearing the cache with clear-cache, a new cache is created.
The first run of a command always creates cache entries (where
appropriate, i.e., not for PUT or POST requests).

The /api/ endpoint is successfully cached and the cached version is
used.

When using the patch command for the second time on the same review
request, if the diff has not been updated, then the cached version of
the /api/review-requests/<id>/diff/<diff_revision>/ endpoint is
used.

This review request was posted with the APICache enabled.

Issues

Description	From	Last Updated
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 24, 2014, 6:38 p.m.
Col: 34 E128 continuation line under-indented for visual indent	reviewbot	Oct. 24, 2014, 6:38 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:38 p.m.
Col: 13 E303 too many blank lines (3)	reviewbot	Oct. 24, 2014, 6:39 p.m.
Col: 9 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:39 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:39 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 32 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
local variable 'kernel' is assigned to but never used	reviewbot	Oct. 24, 2014, 6:37 p.m.
undefined name 'kernal'	reviewbot	Oct. 24, 2014, 6:37 p.m.
'win32com' imported but unused	reviewbot	Oct. 24, 2014, 6:42 p.m.
'windll' imported but unused	reviewbot	Oct. 24, 2014, 6:42 p.m.
'com' imported but unused	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 27, 2014, 8:51 p.m.
'win32com' imported but unused	reviewbot	Oct. 27, 2014, 8:51 p.m.
'windll' imported but unused	reviewbot	Oct. 27, 2014, 8:51 p.m.
'com' imported but unused	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
'win32com' imported but unused	reviewbot	Oct. 27, 2014, 10:02 p.m.
'windll' imported but unused	reviewbot	Oct. 27, 2014, 10:02 p.m.
'com' imported but unused	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 27, 2014, 10:06 p.m.
'win32com' imported but unused	reviewbot	Oct. 27, 2014, 10:06 p.m.
'windll' imported but unused	reviewbot	Oct. 27, 2014, 10:06 p.m.
'com' imported but unused	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 9 E303 too many blank lines (2)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2014, 1:29 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 28, 2014, 1:30 a.m.
'win32com' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
'windll' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
'com' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
'json' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2014, 1:32 a.m.
'win32com' imported but unused	reviewbot	Oct. 28, 2014, 1:32 a.m.
'windll' imported but unused	reviewbot	Oct. 28, 2014, 1:32 a.m.
'com' imported but unused	reviewbot	Oct. 28, 2014, 1:35 a.m.
'json' imported but unused	reviewbot	Oct. 28, 2014, 1:35 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2014, 1:36 a.m.
'win32com' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
'windll' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
'com' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
'json' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 23 E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2014, 12:45 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 31, 2014, 12:43 p.m.
'win32com' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
'windll' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
'com' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
'json' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
Switch these two. (cle before clo)	david	Nov. 10, 2014, 6:49 p.m.
I know that this module is part of the standard library, but is it always guaranteed to work? I don't …	david	Nov. 10, 2014, 6:57 p.m.
Since this will be going into master, and we're bumping the minimum python version, you can change this to just …	david	Nov. 10, 2014, 6:51 p.m.
except OSError as e:	david	Nov. 10, 2014, 6:50 p.m.
This can go away.	david	Nov. 10, 2014, 6:50 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 31, 2014, 12:46 p.m.
'win32com' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
'windll' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
'com' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
'json' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
Can you alphabetize this list?	david	Nov. 10, 2014, 6:50 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 10, 2014, 7:02 p.m.
'win32com' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
'windll' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
'com' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
'json' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 13, 2014, 7:17 p.m.
'win32com' imported but unused	reviewbot	Nov. 13, 2014, 7:17 p.m.
'windll' imported but unused	reviewbot	Nov. 13, 2014, 7:17 p.m.
'com' imported but unused	reviewbot	Nov. 13, 2014, 7:17 p.m.
These should each be using the :file: markup. (I know we don't have that above, but we should there as …	chipx86	Nov. 17, 2014, 7:57 p.m.
We should maybe say the HTTP cache for the API.	chipx86	Nov. 17, 2014, 7:58 p.m.
This and the doc page should match the command: clear-cache	chipx86	Nov. 17, 2014, 7:59 p.m.
We can just import os.	chipx86	Nov. 17, 2014, 8 p.m.
This isn't part of Python, so it must go in import group #2.	chipx86	Nov. 17, 2014, 8 p.m.
This is a Python standard library module, so it can go in the group above.	chipx86	Nov. 17, 2014, 8 p.m.
What's the reason for setting __slots__ here? Generally speaking, there's rarely a reason to actually set this. It can be …	chipx86	Nov. 17, 2014, 8:01 p.m.
The function name and docstring sort of contradict each other.	chipx86	Nov. 17, 2014, 8:02 p.m.
Might be worth mentioning that this is intended to be API-compatible with a urllib2's response object. Same with CachedResponse below. …	chipx86	Nov. 17, 2014, 8:04 p.m.
Can this be a @staticmethod on ApiCache?	chipx86	Nov. 17, 2014, 8:06 p.m.
Trailing period at the end of the log message. Variable on the next line.	chipx86	Nov. 17, 2014, 8:08 p.m.
No blank line here.	chipx86	Nov. 17, 2014, 8:08 p.m.
These could result in exceptions as well, right? Anything we should be catching here? Also, you could skip doing this …	chipx86	Nov. 17, 2014, 8:37 p.m.
No blank line here.	chipx86	Nov. 17, 2014, 8:09 p.m.
Unless we're explicitly needing to worry about the difference between None, empty strings, 0, etc., it's usually best to just …	chipx86	Nov. 17, 2014, 8:11 p.m.
No blank line.	chipx86	Nov. 17, 2014, 8:11 p.m.
In this particular case, it's fine to use \ instead of parens for line continuation.	chipx86	Nov. 17, 2014, 8:11 p.m.
No blank line.	chipx86	Nov. 17, 2014, 8:12 p.m.
"cacheable"	chipx86	Nov. 17, 2014, 8:12 p.m.
No blank line.	chipx86	Nov. 17, 2014, 8:12 p.m.
We return response in all of these cases. We should probably just do a single return response at the end. …	chipx86	Nov. 17, 2014, 9:06 p.m.
Must be on one line. Doc generators will chop it off otherwise.	chipx86	Nov. 17, 2014, 8:14 p.m.
I read this incorrectly at first. Can you add a small comment saying that we restore the old value below? …	chipx86	Nov. 17, 2014, 8:50 p.m.
Blank line between these.	chipx86	Nov. 17, 2014, 8:16 p.m.
expires can be a separate parameter.	chipx86	Nov. 17, 2014, 8:16 p.m.
How about "The C locale is not available on this system. The 'Expires' header cannot be parsed."	chipx86	Nov. 17, 2014, 8:16 p.m.
We should actually grab the old locale and set it, instead of calling resetlocale, in case the caller has actually …	chipx86	Nov. 17, 2014, 8:45 p.m.
No blank line before elif and else. Same below.	chipx86	Nov. 17, 2014, 8:17 p.m.
"posterity's"	chipx86	Nov. 17, 2014, 8:17 p.m.
Should be on the same line. I'd rather not do the map/strip trick inline like this, and like the one …	chipx86	Nov. 17, 2014, 8:31 p.m.
We don't need to check against None unless there's a reason to worry about empty strings and zero. I believe …	chipx86	Nov. 17, 2014, 8:23 p.m.
We should probably catch errors for all these commands.	chipx86	Nov. 18, 2014, 3:11 p.m.
Missing a trailing period.	chipx86	Nov. 17, 2014, 8:23 p.m.
No blank line here.	chipx86	Nov. 17, 2014, 8:19 p.m.
We use dumps to serialize, but are loading above with a custom split. dumps may be too heavy. Can we …	chipx86	Nov. 18, 2014, 12:37 a.m.
"ensures"	chipx86	Nov. 17, 2014, 8:18 p.m.
Swap these.	chipx86	Nov. 17, 2014, 8:19 p.m.
Missing a docstring.	chipx86	Nov. 17, 2014, 8:19 p.m.
How about "Deletes the HTTP cache used for the API."	chipx86	Nov. 17, 2014, 8:20 p.m.
Rather than this, how about a method on ApiCache for deleting the cache?	chipx86	Nov. 17, 2014, 8:21 p.m.
Parameters should go on the line after the log message.	chipx86	Nov. 17, 2014, 8:22 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 13, 2014, 11:16 p.m.
'win32com' imported but unused	reviewbot	Nov. 13, 2014, 11:16 p.m.
'windll' imported but unused	reviewbot	Nov. 13, 2014, 11:16 p.m.
'com' imported but unused	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 13 E303 too many blank lines (2)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 17, 2014, 9:50 p.m.
'win32com' imported but unused	reviewbot	Nov. 17, 2014, 9:50 p.m.
'windll' imported but unused	reviewbot	Nov. 17, 2014, 9:50 p.m.
'com' imported but unused	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 10:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 10:01 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 17, 2014, 10 p.m.
'win32com' imported but unused	reviewbot	Nov. 17, 2014, 10 p.m.
'windll' imported but unused	reviewbot	Nov. 17, 2014, 10 p.m.
'com' imported but unused	reviewbot	Nov. 17, 2014, 10:01 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2014, 3:20 p.m.
'win32com' imported but unused	reviewbot	Nov. 18, 2014, 3:20 p.m.
'windll' imported but unused	reviewbot	Nov. 18, 2014, 3:21 p.m.
'com' imported but unused	reviewbot	Nov. 18, 2014, 3:20 p.m.
Should go up before logging.	chipx86	Nov. 19, 2014, 6:33 a.m.
This blank line should be removed.	chipx86	Nov. 19, 2014, 6:32 a.m.
""" on the next line.	chipx86	Nov. 19, 2014, 6:32 a.m.
Instead of terminating the process, can we just not cache? RBTools is often run in places where it's locked down …	chipx86	Nov. 19, 2014, 2:58 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 8:41 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 18, 2014, 8:41 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2014, 8:41 p.m.
'win32com' imported but unused	reviewbot	Nov. 18, 2014, 8:41 p.m.
'windll' imported but unused	reviewbot	Nov. 18, 2014, 8:41 p.m.
'com' imported but unused	reviewbot	Nov. 18, 2014, 8:41 p.m.
'urlopen' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
undefined name 'urllib2'	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:50 a.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
'urlopen' imported but unused	reviewbot	Nov. 19, 2014, 6:45 a.m.
undefined name 'urllib2'	reviewbot	Nov. 19, 2014, 6:45 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:43 a.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:43 a.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:43 a.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:43 a.m.
Should catch sqlite3.Error here and die gracefully.	brennie	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:52 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:52 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:52 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:52 a.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:52 a.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:52 a.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:52 a.m.
For consistency with the RB database, mind if we use cache_info?	chipx86	Nov. 22, 2014, 11:26 p.m.
And api_cache.	chipx86	Nov. 22, 2014, 11:42 p.m.
"URL"	chipx86	Nov. 22, 2014, 11:29 p.m.
"URL"	chipx86	Nov. 22, 2014, 11:29 p.m.
"If-None-Match"	chipx86	Nov. 22, 2014, 11:31 p.m.
No blank line.	chipx86	Nov. 22, 2014, 11:27 p.m.
No blank line.	chipx86	Nov. 22, 2014, 11:28 p.m.
These are only available in Python 2.7+.	chipx86	Nov. 22, 2014, 11:42 p.m.
"API"	chipx86	Nov. 22, 2014, 11:29 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:03 p.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:03 p.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:03 p.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 22, 2014, 11:53 p.m.
'win32com' imported but unused	reviewbot	Nov. 22, 2014, 11:53 p.m.
'windll' imported but unused	reviewbot	Nov. 22, 2014, 11:53 p.m.
'com' imported but unused	reviewbot	Nov. 22, 2014, 11:53 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 42.

rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 34
 E128 continuation line under-indented for visual indent
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E303 too many blank lines (3)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 32
 E261 at least two spaces before inline comment
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'kernel' is assigned to but never used
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'kernal'
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Formatting.

Commit:

c627b96ab984e257ee15a304c77eb061671d7006

e603220a0073b645e35865515af55dc7b90e5214

Diff:

Revision 2 (+953 -9)

Show changes

	docs/rbtools/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Refactor ApiCache to use dependancy injection so that a mockup urlopen can be used. Fully flesh out behaviour. Write unit tests.

Summary:

[WIP] API Caching

Add API caching support to rbtools.

Description:

~		Add an API caching layer to the `ReviewBoardServer` class. All HTTP requests go through that layer so that they may be cached.
	~	Add the `rbtools.api.cache` module. This module includes the
	+	`ApiCache` class, which allows the results of `HTTP GET` requests to
	+	be cached locally to achieve faster lookup. The `ApiCache` understands
	+	the following headers:
	+
	+	`Cache-Control`
	+	`Pragma`
	+	`Vary`
	+	`Last-Modified`
	+	`ETag`
	+	`Expires`
	+
	+	The `ApiCache` is backed by a SQLite database in the user's cache
	+	directory. If the cache cannot be accessed, the `ApiCache` will pass
	+	all requests to the specified `urlopen` (defaulting to
	+	`urllib2.urlopen`) method.
	+
	+	The `ApiCache` allows for a custom `urlopen` function so that it can
	+	be tested without making actual HTTP requests.
	+
	+	Add the ActiveState `appdirs` module (at version 1.4.0) as
	+	`rbtools.utils.appdirs`. This module is used to find the user cache
	+	directory in platform-dependant ways.
	+
	+	Add the `rbtools.api.cache.Response` class which emulates the
	+	behaviour of a `urllib2` response. This class allows the `read`
	+	method to be called more than once.
	+
	+	Add the `rbtools.api.cache.CachedResponse` class, which is the result
	+	of a cach entry being found the the `ApiCache`. It also emulates the
	+	behaviour of a `urllib2` response.
	+
	+	Added unit tests for the `ApiCache`.

Testing Done:

~		TODO:
	~	Unit tests pass.
-
-		Test if API caching actually works as intendend
-		Write unit tests

Commit:

e603220a0073b645e35865515af55dc7b90e5214

8f6bef0e66611c51057b60e17bdeeb01e10e9ce0

Groups:

students

Diff:

Revision 3 (+1293 -3)

Show changes

	docs/rbtools/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 35.

rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Formatting

Commit:

8f6bef0e66611c51057b60e17bdeeb01e10e9ce0

fdaefc92e256302f66a14b83b62c10685e9afd60

Diff:

Revision 4 (+1294 -3)

Show changes

	docs/rbtools/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues

rbtools/api/cache.py (Diff revision 1)

rbtools/api/cache.py (Diff revision 1)

rbtools/api/cache.py (Diff revision 1)

rbtools/api/cache.py (Diff revision 1)