Summary

Add API caching support to rbtools.

Review Request #6504 — Created Oct. 24, 2014 and submitted Nov. 23, 2014, 1:55 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

~~6608~~, ~~6584~~

Commit

89b50a0...

Reviewers

Groups

rbtools, students

People

Description

Add the rbtools.api.cache module. This module includes the

APICache class, which allows the results of HTTP GET requests to

be cached locally to achieve faster lookup. The APICache understands

the following headers:

Cache-Control
Pragma
Vary
Last-Modified
ETag
Expires

The APICache is backed by a SQLite database in the user's cache

directory. If the cache cannot be accessed, the APICache will pass

all requests to the specified urlopen (defaulting to

urllib2.urlopen) method.
The APICache allows for a custom urlopen function so that it can

be tested without making actual HTTP requests.
The APICache stores the version of its schema in the database. If

the APICache is instantiated and the versions of the schema in the

class doesn't match the version of the schema in the database, then

the current cache will be invalidted and the schema will be updated.
Add the ActiveState appdirs module (at version 1.4.0) as

rbtools.utils.appdirs. This module is used to find the user cache

directory in platform-dependant ways.
Add the rbtools.api.cache.Response class which emulates the

behaviour of a urllib2 response. This class allows the read

method to be called more than once.
Add the rbtools.api.cache.CachedResponse class, which is the result

of a cach entry being found the the APICache. It also emulates the

behaviour of a urllib2 response.
Add the clear-cache command. This command manually clears the API

cache.
Added unit tests for the APICache.

Testing Done

Unit tests pass.

The following commands were tested and were successful:

rbt status
rbt post
rbt diff
rbt patch
rbt close
rbt clear-cache

Upon clearing the cache with clear-cache, a new cache is created.
The first run of a command always creates cache entries (where
appropriate, i.e., not for PUT or POST requests).

The /api/ endpoint is successfully cached and the cached version is
used.

When using the patch command for the second time on the same review
request, if the diff has not been updated, then the cached version of
the /api/review-requests/<id>/diff/<diff_revision>/ endpoint is
used.

This review request was posted with the APICache enabled.

Issues

Description	From	Last Updated
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 24, 2014, 6:38 p.m.
Col: 34 E128 continuation line under-indented for visual indent	reviewbot	Oct. 24, 2014, 6:38 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:38 p.m.
Col: 13 E303 too many blank lines (3)	reviewbot	Oct. 24, 2014, 6:39 p.m.
Col: 9 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:39 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:39 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 32 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:40 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 24, 2014, 6:42 p.m.
local variable 'kernel' is assigned to but never used	reviewbot	Oct. 24, 2014, 6:37 p.m.
undefined name 'kernal'	reviewbot	Oct. 24, 2014, 6:37 p.m.
'win32com' imported but unused	reviewbot	Oct. 24, 2014, 6:42 p.m.
'windll' imported but unused	reviewbot	Oct. 24, 2014, 6:42 p.m.
'com' imported but unused	reviewbot	Oct. 24, 2014, 6:42 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 27, 2014, 8:51 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 27, 2014, 8:51 p.m.
'win32com' imported but unused	reviewbot	Oct. 27, 2014, 8:51 p.m.
'windll' imported but unused	reviewbot	Oct. 27, 2014, 8:51 p.m.
'com' imported but unused	reviewbot	Oct. 27, 2014, 8:50 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:02 p.m.
'win32com' imported but unused	reviewbot	Oct. 27, 2014, 10:02 p.m.
'windll' imported but unused	reviewbot	Oct. 27, 2014, 10:02 p.m.
'com' imported but unused	reviewbot	Oct. 27, 2014, 10:02 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 27, 2014, 10:05 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 27, 2014, 10:06 p.m.
'win32com' imported but unused	reviewbot	Oct. 27, 2014, 10:06 p.m.
'windll' imported but unused	reviewbot	Oct. 27, 2014, 10:06 p.m.
'com' imported but unused	reviewbot	Oct. 27, 2014, 10:06 p.m.
Col: 9 E303 too many blank lines (2)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2014, 1:29 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 28, 2014, 1:30 a.m.
'win32com' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
'windll' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
'com' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
'json' imported but unused	reviewbot	Oct. 28, 2014, 1:30 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:31 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 28, 2014, 1:32 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2014, 1:32 a.m.
'win32com' imported but unused	reviewbot	Oct. 28, 2014, 1:32 a.m.
'windll' imported but unused	reviewbot	Oct. 28, 2014, 1:32 a.m.
'com' imported but unused	reviewbot	Oct. 28, 2014, 1:35 a.m.
'json' imported but unused	reviewbot	Oct. 28, 2014, 1:35 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 28, 2014, 1:36 a.m.
'win32com' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
'windll' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
'com' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
'json' imported but unused	reviewbot	Oct. 28, 2014, 1:36 a.m.
Col: 23 E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2014, 12:45 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:42 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2014, 12:43 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 31, 2014, 12:43 p.m.
'win32com' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
'windll' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
'com' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
'json' imported but unused	reviewbot	Oct. 31, 2014, 12:43 p.m.
Switch these two. (cle before clo)	david	Nov. 10, 2014, 6:49 p.m.
I know that this module is part of the standard library, but is it always guaranteed to work? I don't …	david	Nov. 10, 2014, 6:57 p.m.
Since this will be going into master, and we're bumping the minimum python version, you can change this to just …	david	Nov. 10, 2014, 6:51 p.m.
except OSError as e:	david	Nov. 10, 2014, 6:50 p.m.
This can go away.	david	Nov. 10, 2014, 6:50 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 31, 2014, 12:47 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Oct. 31, 2014, 12:46 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Oct. 31, 2014, 12:46 p.m.
'win32com' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
'windll' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
'com' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
'json' imported but unused	reviewbot	Oct. 31, 2014, 12:46 p.m.
Can you alphabetize this list?	david	Nov. 10, 2014, 6:50 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 10, 2014, 7:01 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 10, 2014, 7:02 p.m.
'win32com' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
'windll' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
'com' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
'json' imported but unused	reviewbot	Nov. 10, 2014, 7:02 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 7:16 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 13, 2014, 7:17 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 13, 2014, 7:17 p.m.
'win32com' imported but unused	reviewbot	Nov. 13, 2014, 7:17 p.m.
'windll' imported but unused	reviewbot	Nov. 13, 2014, 7:17 p.m.
'com' imported but unused	reviewbot	Nov. 13, 2014, 7:17 p.m.
These should each be using the :file: markup. (I know we don't have that above, but we should there as …	chipx86	Nov. 17, 2014, 7:57 p.m.
We should maybe say the HTTP cache for the API.	chipx86	Nov. 17, 2014, 7:58 p.m.
This and the doc page should match the command: clear-cache	chipx86	Nov. 17, 2014, 7:59 p.m.
We can just import os.	chipx86	Nov. 17, 2014, 8 p.m.
This isn't part of Python, so it must go in import group #2.	chipx86	Nov. 17, 2014, 8 p.m.
This is a Python standard library module, so it can go in the group above.	chipx86	Nov. 17, 2014, 8 p.m.
What's the reason for setting __slots__ here? Generally speaking, there's rarely a reason to actually set this. It can be …	chipx86	Nov. 17, 2014, 8:01 p.m.
The function name and docstring sort of contradict each other.	chipx86	Nov. 17, 2014, 8:02 p.m.
Might be worth mentioning that this is intended to be API-compatible with a urllib2's response object. Same with CachedResponse below. …	chipx86	Nov. 17, 2014, 8:04 p.m.
Can this be a @staticmethod on ApiCache?	chipx86	Nov. 17, 2014, 8:06 p.m.
Trailing period at the end of the log message. Variable on the next line.	chipx86	Nov. 17, 2014, 8:08 p.m.
No blank line here.	chipx86	Nov. 17, 2014, 8:08 p.m.
These could result in exceptions as well, right? Anything we should be catching here? Also, you could skip doing this …	chipx86	Nov. 17, 2014, 8:37 p.m.
No blank line here.	chipx86	Nov. 17, 2014, 8:09 p.m.
Unless we're explicitly needing to worry about the difference between None, empty strings, 0, etc., it's usually best to just …	chipx86	Nov. 17, 2014, 8:11 p.m.
No blank line.	chipx86	Nov. 17, 2014, 8:11 p.m.
In this particular case, it's fine to use \ instead of parens for line continuation.	chipx86	Nov. 17, 2014, 8:11 p.m.
No blank line.	chipx86	Nov. 17, 2014, 8:12 p.m.
"cacheable"	chipx86	Nov. 17, 2014, 8:12 p.m.
No blank line.	chipx86	Nov. 17, 2014, 8:12 p.m.
We return response in all of these cases. We should probably just do a single return response at the end. …	chipx86	Nov. 17, 2014, 9:06 p.m.
Must be on one line. Doc generators will chop it off otherwise.	chipx86	Nov. 17, 2014, 8:14 p.m.
I read this incorrectly at first. Can you add a small comment saying that we restore the old value below? …	chipx86	Nov. 17, 2014, 8:50 p.m.
Blank line between these.	chipx86	Nov. 17, 2014, 8:16 p.m.
expires can be a separate parameter.	chipx86	Nov. 17, 2014, 8:16 p.m.
How about "The C locale is not available on this system. The 'Expires' header cannot be parsed."	chipx86	Nov. 17, 2014, 8:16 p.m.
We should actually grab the old locale and set it, instead of calling resetlocale, in case the caller has actually …	chipx86	Nov. 17, 2014, 8:45 p.m.
No blank line before elif and else. Same below.	chipx86	Nov. 17, 2014, 8:17 p.m.
"posterity's"	chipx86	Nov. 17, 2014, 8:17 p.m.
Should be on the same line. I'd rather not do the map/strip trick inline like this, and like the one …	chipx86	Nov. 17, 2014, 8:31 p.m.
We don't need to check against None unless there's a reason to worry about empty strings and zero. I believe …	chipx86	Nov. 17, 2014, 8:23 p.m.
We should probably catch errors for all these commands.	chipx86	Nov. 18, 2014, 3:11 p.m.
Missing a trailing period.	chipx86	Nov. 17, 2014, 8:23 p.m.
No blank line here.	chipx86	Nov. 17, 2014, 8:19 p.m.
We use dumps to serialize, but are loading above with a custom split. dumps may be too heavy. Can we …	chipx86	Nov. 18, 2014, 12:37 a.m.
"ensures"	chipx86	Nov. 17, 2014, 8:18 p.m.
Swap these.	chipx86	Nov. 17, 2014, 8:19 p.m.
Missing a docstring.	chipx86	Nov. 17, 2014, 8:19 p.m.
How about "Deletes the HTTP cache used for the API."	chipx86	Nov. 17, 2014, 8:20 p.m.
Rather than this, how about a method on ApiCache for deleting the cache?	chipx86	Nov. 17, 2014, 8:21 p.m.
Parameters should go on the line after the log message.	chipx86	Nov. 17, 2014, 8:22 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 11:15 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 13, 2014, 11:16 p.m.
'win32com' imported but unused	reviewbot	Nov. 13, 2014, 11:16 p.m.
'windll' imported but unused	reviewbot	Nov. 13, 2014, 11:16 p.m.
'com' imported but unused	reviewbot	Nov. 13, 2014, 11:16 p.m.
Col: 13 E303 too many blank lines (2)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 17, 2014, 9:49 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 17, 2014, 9:50 p.m.
'win32com' imported but unused	reviewbot	Nov. 17, 2014, 9:50 p.m.
'windll' imported but unused	reviewbot	Nov. 17, 2014, 9:50 p.m.
'com' imported but unused	reviewbot	Nov. 17, 2014, 9:50 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 10:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 17, 2014, 10:01 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 17, 2014, 10 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 17, 2014, 10 p.m.
'win32com' imported but unused	reviewbot	Nov. 17, 2014, 10 p.m.
'windll' imported but unused	reviewbot	Nov. 17, 2014, 10 p.m.
'com' imported but unused	reviewbot	Nov. 17, 2014, 10:01 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 18, 2014, 3:20 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2014, 3:20 p.m.
'win32com' imported but unused	reviewbot	Nov. 18, 2014, 3:20 p.m.
'windll' imported but unused	reviewbot	Nov. 18, 2014, 3:21 p.m.
'com' imported but unused	reviewbot	Nov. 18, 2014, 3:20 p.m.
Should go up before logging.	chipx86	Nov. 19, 2014, 6:33 a.m.
This blank line should be removed.	chipx86	Nov. 19, 2014, 6:32 a.m.
""" on the next line.	chipx86	Nov. 19, 2014, 6:32 a.m.
Instead of terminating the process, can we just not cache? RBTools is often run in places where it's locked down …	chipx86	Nov. 19, 2014, 2:58 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 8:41 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 18, 2014, 8:40 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 18, 2014, 8:41 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2014, 8:41 p.m.
'win32com' imported but unused	reviewbot	Nov. 18, 2014, 8:41 p.m.
'windll' imported but unused	reviewbot	Nov. 18, 2014, 8:41 p.m.
'com' imported but unused	reviewbot	Nov. 18, 2014, 8:41 p.m.
'urlopen' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
undefined name 'urllib2'	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:50 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:50 a.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:50 a.m.
'urlopen' imported but unused	reviewbot	Nov. 19, 2014, 6:45 a.m.
undefined name 'urllib2'	reviewbot	Nov. 19, 2014, 6:45 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:44 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:43 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:43 a.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:43 a.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:43 a.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:43 a.m.
Should catch sqlite3.Error here and die gracefully.	brennie	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:51 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:52 a.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:52 a.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:52 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:52 a.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:52 a.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:52 a.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:52 a.m.
For consistency with the RB database, mind if we use cache_info?	chipx86	Nov. 22, 2014, 11:26 p.m.
And api_cache.	chipx86	Nov. 22, 2014, 11:42 p.m.
"URL"	chipx86	Nov. 22, 2014, 11:29 p.m.
"URL"	chipx86	Nov. 22, 2014, 11:29 p.m.
"If-None-Match"	chipx86	Nov. 22, 2014, 11:31 p.m.
No blank line.	chipx86	Nov. 22, 2014, 11:27 p.m.
No blank line.	chipx86	Nov. 22, 2014, 11:28 p.m.
These are only available in Python 2.7+.	chipx86	Nov. 22, 2014, 11:42 p.m.
"API"	chipx86	Nov. 22, 2014, 11:29 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:04 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2014, 6:03 p.m.
'win32com' imported but unused	reviewbot	Nov. 19, 2014, 6:03 p.m.
'windll' imported but unused	reviewbot	Nov. 19, 2014, 6:03 p.m.
'com' imported but unused	reviewbot	Nov. 19, 2014, 6:03 p.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 38 E261 at least two spaces before inline comment	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 10 E261 at least two spaces before inline comment	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (122 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (116 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Nov. 22, 2014, 11:52 p.m.
Col: 80 E501 line too long (115 > 79 characters)	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 30 E128 continuation line under-indented for visual indent	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 1 E265 block comment should start with '# '	reviewbot	Nov. 22, 2014, 11:53 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Nov. 22, 2014, 11:53 p.m.
'win32com' imported but unused	reviewbot	Nov. 22, 2014, 11:53 p.m.
'windll' imported but unused	reviewbot	Nov. 22, 2014, 11:53 p.m.
'com' imported but unused	reviewbot	Nov. 22, 2014, 11:53 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 42.

rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 34
 E128 continuation line under-indented for visual indent
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E303 too many blank lines (3)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 32
 E261 at least two spaces before inline comment
```
rbtools/api/cache.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'kernel' is assigned to but never used
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'kernal'
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Formatting.

Commit:

c627b96ab984e257ee15a304c77eb061671d7006

e603220a0073b645e35865515af55dc7b90e5214

Diff:

Revision 2 (+953 -9)

Show changes

	docs/rbtools/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/utils/appdirs.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Refactor ApiCache to use dependancy injection so that a mockup urlopen can be used. Fully flesh out behaviour. Write unit tests.

Summary:

[WIP] API Caching

Add API caching support to rbtools.

Description:

~		Add an API caching layer to the `ReviewBoardServer` class. All HTTP requests go through that layer so that they may be cached.
	~	Add the `rbtools.api.cache` module. This module includes the
	+	`ApiCache` class, which allows the results of `HTTP GET` requests to
	+	be cached locally to achieve faster lookup. The `ApiCache` understands
	+	the following headers:
	+
	+	`Cache-Control`
	+	`Pragma`
	+	`Vary`
	+	`Last-Modified`
	+	`ETag`
	+	`Expires`
	+
	+	The `ApiCache` is backed by a SQLite database in the user's cache
	+	directory. If the cache cannot be accessed, the `ApiCache` will pass
	+	all requests to the specified `urlopen` (defaulting to
	+	`urllib2.urlopen`) method.
	+
	+	The `ApiCache` allows for a custom `urlopen` function so that it can
	+	be tested without making actual HTTP requests.
	+
	+	Add the ActiveState `appdirs` module (at version 1.4.0) as
	+	`rbtools.utils.appdirs`. This module is used to find the user cache
	+	directory in platform-dependant ways.
	+
	+	Add the `rbtools.api.cache.Response` class which emulates the
	+	behaviour of a `urllib2` response. This class allows the `read`
	+	method to be called more than once.
	+
	+	Add the `rbtools.api.cache.CachedResponse` class, which is the result
	+	of a cach entry being found the the `ApiCache`. It also emulates the
	+	behaviour of a `urllib2` response.
	+
	+	Added unit tests for the `ApiCache`.

Testing Done:

~		TODO:
	~	Unit tests pass.
-
-		Test if API caching actually works as intendend
-		Write unit tests

Commit:

e603220a0073b645e35865515af55dc7b90e5214

8f6bef0e66611c51057b60e17bdeeb01e10e9ce0

Groups:

students

Diff:

Revision 3 (+1293 -3)

Show changes

	docs/rbtools/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 35.

rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/api/cache.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Formatting

Commit:

8f6bef0e66611c51057b60e17bdeeb01e10e9ce0

fdaefc92e256302f66a14b83b62c10685e9afd60

Diff:

Revision 4 (+1294 -3)

Show changes

	docs/rbtools/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/utils/COPYING.appdirs
	rbtools/utils/README.appdirs
	rbtools/utils/appdirs.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/api/request.py
    rbtools/api/cache.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Add rbt clear-cache command and its documentation.

Code cleanup and documentation.

Description:

		Add the `rbtools.api.cache` module. This module includes the
		`ApiCache` class, which allows the results of `HTTP GET` requests to
		be cached locally to achieve faster lookup. The `ApiCache` understands
		the following headers:

		`Cache-Control`
		`Pragma`
		`Vary`
		`Last-Modified`
		`ETag`
		`Expires`

		The `ApiCache` is backed by a SQLite database in the user's cache
		directory. If the cache cannot be accessed, the `ApiCache` will pass
		all requests to the specified `urlopen` (defaulting to
		`urllib2.urlopen`) method.

		The `ApiCache` allows for a custom `urlopen` function so that it can
		be tested without making actual HTTP requests.

		Add the ActiveState `appdirs` module (at version 1.4.0) as
		`rbtools.utils.appdirs`. This module is used to find the user cache
		directory in platform-dependant ways.

		Add the `rbtools.api.cache.Response` class which emulates the
		behaviour of a `urllib2` response. This class allows the `read`
		method to be called more than once.

		Add the `rbtools.api.cache.CachedResponse` class, which is the result
		of a cach entry being found the the `ApiCache`. It also emulates the
		behaviour of a `urllib2` response.

	+	Add the `clear-cache` command. This command manually clears the API
	+	cache.
	+
		Added unit tests for the `ApiCache`.

Commit:

fdaefc92e256302f66a14b83b62c10685e9afd60

a51d81966f9a47a0a308caf69fac855a940e4051

Diff:

Revision 5 (+1371 -3)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 34.

rbtools/api/cache.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```
rbtools/commands/clearcache.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```
setup.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'json' imported but unused
```

Change Summary:

Formatting.

Commit:

a51d81966f9a47a0a308caf69fac855a940e4051

d8cd9cdcc7fa41dc1bfe74469a5a390bdcf37e75

Diff:

Revision 6 (+1372 -3)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```
setup.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'json' imported but unused
```

Change Summary:

Fix formatting and a typo.

Commit:

d8cd9cdcc7fa41dc1bfe74469a5a390bdcf37e75

51df36687952c5ef71bd31903af69a534aae9b45

Diff:

Revision 7 (+1371 -3)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```
setup.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'json' imported but unused
```

Change Summary:: Add todo to description.
Summary:: Add API caching support to rbtools.
[WIP] Add API caching support to rbtools.
Description:: Add the rbtools.api.cache module. This module includes the
ApiCache class, which allows the results of HTTP GET requests to
be cached locally to achieve faster lookup. The ApiCache understands
the following headers:

Cache-Control

Pragma

Vary

Last-Modified

ETag

Expires

The ApiCache is backed by a SQLite database in the user's cache
directory. If the cache cannot be accessed, the ApiCache will pass
all requests to the specified urlopen (defaulting to
urllib2.urlopen) method.

The ApiCache allows for a custom urlopen function so that it can
be tested without making actual HTTP requests.

Add the ActiveState appdirs module (at version 1.4.0) as
rbtools.utils.appdirs. This module is used to find the user cache
directory in platform-dependant ways.

Add the rbtools.api.cache.Response class which emulates the
behaviour of a urllib2 response. This class allows the read
method to be called more than once.

Add the rbtools.api.cache.CachedResponse class, which is the result
of a cach entry being found the the ApiCache. It also emulates the
behaviour of a urllib2 response.

Add the clear-cache command. This command manually clears the API
cache.

Added unit tests for the ApiCache.
+
+
TODO:
+ - Allow the ApiCache to be invalidated, eg by an update to the schema.
+ The db should have an Info table with a version field that
+ indicates the current schema version. The ApiCache should request this
+ value on startup and if it is out of date with the version in the class,
+ it should invalidate (i.e. wipe) the cache.
+ - Handle special case that when Vary: header field changes, we should check
+ if a record exists for the url, new headers tuple before blindly inserting
+ because this may violate the (url, headers) uniqueness constraint.

Change Summary:

Allow ApiCache to be invalidated.

Move ApiCache._insert_entry and ApiCache._update_entry to ApiCache._save_entry which performs the funcationality of both.

Description:

		Add the `rbtools.api.cache` module. This module includes the
		`ApiCache` class, which allows the results of `HTTP GET` requests to
		be cached locally to achieve faster lookup. The `ApiCache` understands
		the following headers:

		`Cache-Control`
		`Pragma`
		`Vary`
		`Last-Modified`
		`ETag`
		`Expires`

		The `ApiCache` is backed by a SQLite database in the user's cache
		directory. If the cache cannot be accessed, the `ApiCache` will pass
		all requests to the specified `urlopen` (defaulting to
		`urllib2.urlopen`) method.

		The `ApiCache` allows for a custom `urlopen` function so that it can
		be tested without making actual HTTP requests.

	+	The `ApiCache` stores the version of its schema in the database. If
	+	the `ApiCache` is instantiated and the versions of the schema in the
	+	class doesn't match the version of the schema in the database, then
	+	the current cache will be invalidted and the schema will be updated.
	+
		Add the ActiveState `appdirs` module (at version 1.4.0) as
		`rbtools.utils.appdirs`. This module is used to find the user cache
		directory in platform-dependant ways.

		Add the `rbtools.api.cache.Response` class which emulates the
		behaviour of a `urllib2` response. This class allows the `read`
		method to be called more than once.

		Add the `rbtools.api.cache.CachedResponse` class, which is the result
		of a cach entry being found the the `ApiCache`. It also emulates the
		behaviour of a `urllib2` response.

		Add the `clear-cache` command. This command manually clears the API
		cache.

		Added unit tests for the `ApiCache`.
-
-		TODO:
-		- Allow the ApiCache to be invalidated, eg by an update to the schema.
-		The db should have an `Info` table with a version field that
-		indicates the current schema version. The ApiCache should request this
-		value on startup and if it is out of date with the version in the class,
-		it should invalidate (i.e. wipe) the cache.
-		- Handle special case that when Vary: header field changes, we should check
-		if a record exists for the url, new headers tuple before blindly inserting
-		because this may violate the (url, headers) uniqueness constraint.

Commit:

51df36687952c5ef71bd31903af69a534aae9b45

62a5c47b9ec5ea52c88efeb4c3a4e38a7eb66719

Diff:

Revision 8 (+1393 -3)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Change Summary:: Move out of WIP
Summary:: [WIP] Add API caching support to rbtools.
Add API caching support to rbtools.

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 33.

rbtools/api/cache.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Col: 23
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```
setup.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'json' imported but unused
```

Change Summary:

Formatting.

Commit:

62a5c47b9ec5ea52c88efeb4c3a4e38a7eb66719

d5421aa791e6b5eced10dada42388d4ded15ebb9

Diff:

Revision 9 (+1398 -3)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```
setup.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'json' imported but unused
```

docs/rbtools/rbt/commands/index.rst (Diff revision 9)
The issue has been resolved. Show all issues
```
Switch these two. (cle before clo)
```

rbtools/api/cache.py (Diff revision 9)

The issue has been dropped. Show all issues

I know that this module is part of the standard library, but is it always guaranteed to work? I don't want users to have to install anything other than python.

brennie

Nov. 10, 2014, 6:57 p.m.

The shared C library behind sqlite3 is distributed with Python 2.5+.

rbtools/api/cache.py (Diff revision 9)

The issue has been resolved. Show all issues

Since this will be going into master, and we're bumping the minimum python version, you can change this to just be import json and use json.loads and json.dumps

rbtools/api/cache.py (Diff revision 9)
The issue has been resolved. Show all issues
```
except OSError as e:
```
rbtools/api/cache.py (Diff revision 9)
The issue has been resolved. Show all issues
```
This can go away.
```
setup.py (Diff revision 9)
The issue has been resolved. Show all issues
```
Can you alphabetize this list?
```

Change Summary:

Fix issues in David's review.

Commit:

d5421aa791e6b5eced10dada42388d4ded15ebb9

af9417d5c4d0c1e889f879fb0de1ea74c2965145

Diff:

Revision 10 (+1392 -4)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```
setup.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'json' imported but unused
```

This change looks pretty good to me, but I'd like some details on manual testing of the individual rbtools commands.

Change Summary:

Write the API cache to disk. Do not treat 304 as an error code.

Add debugging logs.

Commit:

af9417d5c4d0c1e889f879fb0de1ea74c2965145

75fc708596acda760475263b6540df4d1d7fb0df

Diff:

Revision 11 (+1416 -5)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Add dependancy on r/6548 so that six.iteritems can be used.

Cache the Vary Headers correctly -- if none are sent, we need to record that none were sent.

Minor formatting and rename headers to vary_headers when referring specifically to the Vary header

Add testing info.

Testing Done:

~		Unit tests pass.
	~	The following commands were tested and were successful:
	+
	+	`rbt status`
	+	`rbt post`
	+	`rbt diff`
	+	`rbt patch`
	+	`rbt close`
	+	`rbt clear-cache`
	+
	+	Upon clearing the cache with `clear-cache`, a new cache is created.
	+	The first run of a command always creates cache entries (where
	+	appropriate, i.e., not for PUT or POST requests).
	+
	+	The `/api/` endpoint is successfully cached and the cached version is
	+	used.
	+
	+	When using the `patch` command for the second time on the same review
	+	request, if the diff has not been updated, then the cached version of
	+	the `/api/review-requests/<id>/diff/<diff_revision>/` endpoint is
	+	used.
	+
	+	This review request was posted with the `ApiCache` enabled.

Depends On:

~~6584 - Add a dependency on 'six'~~

Diff:

Revision 12 (+1414 -7)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clearcache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/rbt/commands/clearcache.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:: Add note about unit tests passing.
Testing Done:: +
Unit tests pass.
+

The following commands were tested and were successful:

rbt status

rbt post

rbt diff

rbt patch

rbt close

rbt clear-cache

Upon clearing the cache with clear-cache, a new cache is created.
The first run of a command always creates cache entries (where
appropriate, i.e., not for PUT or POST requests).

The /api/ endpoint is successfully cached and the cached version is
used.

When using the patch command for the second time on the same review
request, if the diff has not been updated, then the cached version of
the /api/review-requests/<id>/diff/<diff_revision>/ endpoint is
used.

This review request was posted with the ApiCache enabled.

<p>Looking pretty awesome!</p>

<p>Caught some typos and style differences. The general logic looks pretty thorough and correct from what I can tell so far.</p>

chipx86

Nov. 17, 2014, 3:42 a.m.

Hah. That's what I get for not reloading this page after deploying the fix for this... (Went crazy trying to figure out how this bug was still occurring at first.)

docs/rbtools/index.rst (Diff revision 12)

The issue has been resolved. Show all issues

These should each be using the :file: markup. (I know we don't have that above, but we should there as well.)

:file:`~/.cache/.rbtools/apicache.db`

docs/rbtools/rbt/commands/clearcache.rst (Diff revision 12)
The issue has been resolved. Show all issues
```
We should maybe say the HTTP cache for the API.
```
docs/rbtools/rbt/commands/index.rst (Diff revision 12)
The issue has been resolved. Show all issues
```
This and the doc page should match the command: clear-cache
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
We can just import os.
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
This isn't part of Python, so it must go in import group #2.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

This is a Python standard library module, so it can go in the group above.

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

What's the reason for setting __slots__ here?

Generally speaking, there's rarely a reason to actually set this. It can be used for memory performance reasons, but unless we're expecting a large number of these to stick around in memory for a while, we probably don't gain enough to warrant here.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
The function name and docstring sort of contradict each other.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

Might be worth mentioning that this is intended to be API-compatible with a urllib2's response object. Same with CachedResponse below.

Also, maybe we should call this HTTPResponse? And CachedHTTPResponse below? Just to make it more specific. (Not sure, just floating the idea.)

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Can this be a @staticmethod on ApiCache?
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

Trailing period at the end of the log message.

Variable on the next line.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line here.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

These could result in exceptions as well, right? Anything we should be catching here?

Also, you could skip doing this connect twice by doing:

cache_is_new = not os.path.exists(self.cache_path):

if cache_is_new:
    # All the setup stuff for creating

self.db = sqlite3.connect(...)

if not cache_is_new:
    # Check version, etc.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line here.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

Unless we're explicitly needing to worry about the difference between None, empty strings, 0, etc., it's usually best to just do if entry:.

Same below.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

In this particular case, it's fine to use \ instead of parens for line continuation.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line.
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
"cacheable"
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

We return response in all of these cases. We should probably just do a single return response at the end.
The code above that returns a CachedResponse can just assign that to response to take advantage of the single exit point.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Must be on one line. Doc generators will chop it off otherwise.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

I read this incorrectly at first. Can you add a small comment saying that we restore the old value below?

Also, this isn't thread-safe. Not a massive deal right now, but potentially problematic later. Easily fixed with doing all this in a threading.Lock().

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
expires can be a separate parameter.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

How about "The C locale is not available on this system. The 'Expires' header cannot be parsed."

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

We should actually grab the old locale and set it, instead of calling resetlocale, in case the caller has actually set a custom locale before all this.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line before elif and else.
Same below.
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
"posterity's"
```

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

Should be on the same line.
I'd rather not do the map/strip trick inline like this, and like the one above. Instead, can we make a utility function for parsing headr values, and use a list comprehension?
return [
    s.strip()
    for s in headers.split(',')
]

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

We don't need to check against None unless there's a reason to worry about empty strings and zero. I believe those values are just as None-worthy as None for our purposes.

rbtools/api/cache.py (Diff revision 12)

The issue has been resolved. Show all issues

We should probably catch errors for all these commands.

brennie

Nov. 18, 2014, 10:41 a.m.

Do you mean specifically these two, all calls to execute in _create_schema, or all calls to execute in the ApiCache.

chipx86

Nov. 18, 2014, 1:54 p.m.

Probably all calls. Things can go wrong, and it'd be better to present that in a controlled way.

rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Missing a trailing period.
```
rbtools/api/cache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
No blank line here.
```

rbtools/api/cache.py (Diff revision 12)

The issue has been dropped. Show all issues

We use dumps to serialize, but are loading above with a custom split. dumps may be too heavy. Can we just do a join?

rbtools/api/request.py (Diff revision 12)
The issue has been resolved. Show all issues
```
"ensures"
```
rbtools/commands/clearcache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Swap these.
```
rbtools/commands/clearcache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Missing a docstring.
```
rbtools/commands/clearcache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
How about "Deletes the HTTP cache used for the API."
```
rbtools/commands/clearcache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Rather than this, how about a method on ApiCache for deleting the cache?
```
rbtools/commands/clearcache.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Parameters should go on the line after the log message.
```

Change Summary:

Fix most issues outline in Christian's review.

Commit:

75fc708596acda760475263b6540df4d1d7fb0df

6daa3bb7890476147224b5cd959cad465a86de64

Diff:

Revision 13 (+1429 -10)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 34.

rbtools/api/cache.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 13
 E303 too many blank lines (2)
```
rbtools/api/cache.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Formatting. Fix _split_csv usage.

Commit:

6daa3bb7890476147224b5cd959cad465a86de64

4d80bfe6d1e37a1a777a3453419025f50e4fe206

Diff:

Revision 14 (+1429 -10)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Catch exceptions around DB interaction and die gracefully. Rename ApiCache to APICache.

Description:

		Add the `rbtools.api.cache` module. This module includes the
~		`ApiCache` class, which allows the results of `HTTP GET` requests to
~		be cached locally to achieve faster lookup. The `ApiCache` understands
	~	`APICache` class, which allows the results of `HTTP GET` requests to
	~	be cached locally to achieve faster lookup. The `APICache` understands
		the following headers:

		`Cache-Control`
		`Pragma`
		`Vary`
		`Last-Modified`
		`ETag`
		`Expires`

~		The `ApiCache` is backed by a SQLite database in the user's cache
~		directory. If the cache cannot be accessed, the `ApiCache` will pass
	~	The `APICache` is backed by a SQLite database in the user's cache
	~	directory. If the cache cannot be accessed, the `APICache` will pass
		all requests to the specified `urlopen` (defaulting to
		`urllib2.urlopen`) method.

~		The `ApiCache` allows for a custom `urlopen` function so that it can
	~	The `APICache` allows for a custom `urlopen` function so that it can
		be tested without making actual HTTP requests.

~		The `ApiCache` stores the version of its schema in the database. If
~		the `ApiCache` is instantiated and the versions of the schema in the
	~	The `APICache` stores the version of its schema in the database. If
	~	the `APICache` is instantiated and the versions of the schema in the
		class doesn't match the version of the schema in the database, then
		the current cache will be invalidted and the schema will be updated.

		Add the ActiveState `appdirs` module (at version 1.4.0) as
		`rbtools.utils.appdirs`. This module is used to find the user cache
		directory in platform-dependant ways.

		Add the `rbtools.api.cache.Response` class which emulates the
		behaviour of a `urllib2` response. This class allows the `read`
		method to be called more than once.

		Add the `rbtools.api.cache.CachedResponse` class, which is the result
~		of a cach entry being found the the `ApiCache`. It also emulates the
	~	of a cach entry being found the the `APICache`. It also emulates the
		behaviour of a `urllib2` response.

		Add the `clear-cache` command. This command manually clears the API
		cache.

~		Added unit tests for the `ApiCache`.
	~	Added unit tests for the `APICache`.

Testing Done:

		Unit tests pass.

		The following commands were tested and were successful:

		`rbt status`
		`rbt post`
		`rbt diff`
		`rbt patch`
		`rbt close`
		`rbt clear-cache`

		Upon clearing the cache with `clear-cache`, a new cache is created.
		The first run of a command always creates cache entries (where
		appropriate, i.e., not for PUT or POST requests).

		The `/api/` endpoint is successfully cached and the cached version is
		used.

		When using the `patch` command for the second time on the same review
		request, if the diff has not been updated, then the cached version of
		the `/api/review-requests/<id>/diff/<diff_revision>/` endpoint is
		used.

~		This review request was posted with the `ApiCache` enabled.
	~	This review request was posted with the `APICache` enabled.

Commit:

4d80bfe6d1e37a1a777a3453419025f50e4fe206

4dae797d0162a1d4cc7be4a70eebc45d3db6a95c

Diff:

Revision 15 (+1466 -10)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Use six.moves for urlopen

Commit:

4dae797d0162a1d4cc7be4a70eebc45d3db6a95c

7a11e691618eabfae4cf7dc22efed117e43d312d

Diff:

Revision 16 (+1466 -10)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Looking great! Only a few small things left.

rbtools/api/cache.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Should go up before logging.
```
rbtools/api/cache.py (Diff revision 16)
The issue has been resolved. Show all issues
```
This blank line should be removed.
```
rbtools/api/cache.py (Diff revision 16)
The issue has been resolved. Show all issues
```
""" on the next line.
```

rbtools/api/cache.py (Diff revision 16)

The issue has been dropped. Show all issues

Instead of terminating the process, can we just not cache? RBTools is often run in places where it's locked down and would never be able to create a cache.

brennie

Nov. 19, 2014, 6:32 a.m.

APICache._die is only called in instances where something has gone wrong after connecting to the database. If a connection cannot be made to the db (see rbtools/api/cache.py lines 177--186), then _die is not called, and instead caching is disabled. Is this behaviour adequate.

chipx86

Nov. 19, 2014, 2:56 p.m.

Yeah, I think that's okay. So long as the cache database is optional if it can't be written to.

Change Summary:

Rebased off master. Fixed some of Christian's issues.

Commit:

7a11e691618eabfae4cf7dc22efed117e43d312d

b7dad8144b2faec94be41fa994d2c66d4ca70849

Diff:

Revision 17 (+1467 -11)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/api/request.py (Diff revision 17)
The issue has been resolved. Show all issues
```
 'urlopen' imported but unused
```
rbtools/api/request.py (Diff revision 17)
The issue has been resolved. Show all issues
```
 undefined name 'urllib2'
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Make this review request depend on David's Use six.moves for StringIO review request.

Depends On:

~~6608 - Use six.moves for StringIO~~

Diff:

Revision 18 (+1467 -11)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/api/request.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 'urlopen' imported but unused
```
rbtools/api/request.py (Diff revision 18)
The issue has been resolved. Show all issues
```
 undefined name 'urllib2'
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Change Summary:

Fix some import issues.

Diff:

Revision 19 (+1467 -12)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

rbtools/api/cache.py (Diff revision 19)
The issue has been resolved. Show all issues
```
Should catch sqlite3.Error here and die gracefully.
```

Change Summary:

Add a try..except around the last DB operation.

Commit:

b7dad8144b2faec94be41fa994d2c66d4ca70849

70ecb18842064c517f0628b59166c57d07c74bca

Diff:

Revision 20 (+1477 -21)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	4 more

Tool: Pyflakes
Processed Files:
    rbtools/utils/testbase.py
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/utils/testbase.py
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 20)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

A few things I didn't catch before. I don't see anything beyond these though. :)

rbtools/api/cache.py (Diff revision 20)
The issue has been resolved. Show all issues
```
For consistency with the RB database, mind if we use cache_info?
```
rbtools/api/cache.py (Diff revision 20)
The issue has been resolved. Show all issues
```
And api_cache.
```
rbtools/api/tests.py (Diff revision 20)
The issue has been resolved. Show all issues
```
"URL"
```
rbtools/api/tests.py (Diff revision 20)
The issue has been resolved. Show all issues
```
"URL"
```
rbtools/api/tests.py (Diff revision 20)
The issue has been resolved. Show all issues
```
"If-None-Match"
```
rbtools/api/tests.py (Diff revision 20)
The issue has been resolved. Show all issues
```
No blank line.
```
rbtools/api/tests.py (Diff revision 20)
The issue has been resolved. Show all issues
```
No blank line.
```
rbtools/api/tests.py (Diff revision 20)
The issue has been resolved. Show all issues
```
These are only available in Python 2.7+.
```
rbtools/commands/clearcache.py (Diff revision 20)
The issue has been resolved. Show all issues
```
"API"
```

Change Summary:

Rename APICache -> api_cache and CacheInfo -> cache_info in database.

Switch to using assertTrue/assertFalse with isinstance instead of assertIsInstanceOf/assertIsNotInstanceOf in tests.

Commit:

70ecb18842064c517f0628b59166c57d07c74bca

89b50a0c9afb40e80f761b7ba5ddbb9d6b2a5320

Diff:

Revision 21 (+1472 -12)

Show changes

	setup.py
	docs/rbtools/index.rst
	docs/rbtools/rbt/commands/clear-cache.rst
	docs/rbtools/rbt/commands/index.rst
	rbtools/api/cache.py
	rbtools/api/request.py
	rbtools/api/tests.py
	rbtools/commands/clearcache.py
	3 more

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/utils/appdirs.py
    rbtools/commands/clearcache.py
    rbtools/api/cache.py
    setup.py
    rbtools/api/request.py

Ignored Files:
    rbtools/utils/COPYING.appdirs
    docs/rbtools/rbt/commands/clear-cache.rst
    rbtools/utils/README.appdirs
    docs/rbtools/rbt/commands/index.rst
    docs/rbtools/index.rst


WARNING: Number of comments exceeded maximum, showing 30 of 32.

rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 38
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 10
 E261 at least two spaces before inline comment
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (122 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (116 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (115 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 30
 E128 continuation line under-indented for visual indent
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 1
 E265 block comment should start with '# '
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
 'win32com' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
 'windll' imported but unused
```
rbtools/utils/appdirs.py (Diff revision 21)
The issue has been dropped. Show all issues
```
 'com' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (a630b0e)