Add API caching support to rbtools.

Review Request #6504 — Created Oct. 24, 2014 and submitted

Information

RBTools
master
89b50a0...

Reviewers

Add the rbtools.api.cache module. This module includes the
APICache class, which allows the results of HTTP GET requests to
be cached locally to achieve faster lookup. The APICache understands
the following headers:

  • Cache-Control
  • Pragma
  • Vary
  • Last-Modified
  • ETag
  • Expires

The APICache is backed by a SQLite database in the user's cache
directory. If the cache cannot be accessed, the APICache will pass
all requests to the specified urlopen (defaulting to
urllib2.urlopen) method.

The APICache allows for a custom urlopen function so that it can
be tested without making actual HTTP requests.

The APICache stores the version of its schema in the database. If
the APICache is instantiated and the versions of the schema in the
class doesn't match the version of the schema in the database, then
the current cache will be invalidted and the schema will be updated.

Add the ActiveState appdirs module (at version 1.4.0) as
rbtools.utils.appdirs. This module is used to find the user cache
directory in platform-dependant ways.

Add the rbtools.api.cache.Response class which emulates the
behaviour of a urllib2 response. This class allows the read
method to be called more than once.

Add the rbtools.api.cache.CachedResponse class, which is the result
of a cach entry being found the the APICache. It also emulates the
behaviour of a urllib2 response.

Add the clear-cache command. This command manually clears the API
cache.

Added unit tests for the APICache.

Unit tests pass.

The following commands were tested and were successful:

  • rbt status
  • rbt post
  • rbt diff
  • rbt patch
  • rbt close
  • rbt clear-cache

Upon clearing the cache with clear-cache, a new cache is created.
The first run of a command always creates cache entries (where
appropriate, i.e., not for PUT or POST requests).

The /api/ endpoint is successfully cached and the cached version is
used.

When using the patch command for the second time on the same review
request, if the diff has not been updated, then the cached version of
the /api/review-requests/<id>/diff/<diff_revision>/ endpoint is
used.

This review request was posted with the APICache enabled.

Description From Last Updated

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 34 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 13 E303 too many blank lines (3)

reviewbotreviewbot

Col: 9 E303 too many blank lines (2)

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 80 E501 line too long (88 > 79 characters)

reviewbotreviewbot

Col: 32 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 1 W391 blank line at end of file

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

local variable 'kernel' is assigned to but never used

reviewbotreviewbot

undefined name 'kernal'

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 9 E303 too many blank lines (2)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 23 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Switch these two. (cle before clo)

daviddavid

I know that this module is part of the standard library, but is it always guaranteed to work? I don't …

daviddavid

Since this will be going into master, and we're bumping the minimum python version, you can change this to just …

daviddavid

except OSError as e:

daviddavid

This can go away.

daviddavid

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Can you alphabetize this list?

daviddavid

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'json' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

These should each be using the :file: markup. (I know we don't have that above, but we should there as …

chipx86chipx86

We should maybe say the HTTP cache for the API.

chipx86chipx86

This and the doc page should match the command: clear-cache

chipx86chipx86

We can just import os.

chipx86chipx86

This isn't part of Python, so it must go in import group #2.

chipx86chipx86

This is a Python standard library module, so it can go in the group above.

chipx86chipx86

What's the reason for setting __slots__ here? Generally speaking, there's rarely a reason to actually set this. It can be …

chipx86chipx86

The function name and docstring sort of contradict each other.

chipx86chipx86

Might be worth mentioning that this is intended to be API-compatible with a urllib2's response object. Same with CachedResponse below. …

chipx86chipx86

Can this be a @staticmethod on ApiCache?

chipx86chipx86

Trailing period at the end of the log message. Variable on the next line.

chipx86chipx86

No blank line here.

chipx86chipx86

These could result in exceptions as well, right? Anything we should be catching here? Also, you could skip doing this …

chipx86chipx86

No blank line here.

chipx86chipx86

Unless we're explicitly needing to worry about the difference between None, empty strings, 0, etc., it's usually best to just …

chipx86chipx86

No blank line.

chipx86chipx86

In this particular case, it's fine to use \ instead of parens for line continuation.

chipx86chipx86

No blank line.

chipx86chipx86

"cacheable"

chipx86chipx86

No blank line.

chipx86chipx86

We return response in all of these cases. We should probably just do a single return response at the end. …

chipx86chipx86

Must be on one line. Doc generators will chop it off otherwise.

chipx86chipx86

I read this incorrectly at first. Can you add a small comment saying that we restore the old value below? …

chipx86chipx86

Blank line between these.

chipx86chipx86

expires can be a separate parameter.

chipx86chipx86

How about "The C locale is not available on this system. The 'Expires' header cannot be parsed."

chipx86chipx86

We should actually grab the old locale and set it, instead of calling resetlocale, in case the caller has actually …

chipx86chipx86

No blank line before elif and else. Same below.

chipx86chipx86

"posterity's"

chipx86chipx86

Should be on the same line. I'd rather not do the map/strip trick inline like this, and like the one …

chipx86chipx86

We don't need to check against None unless there's a reason to worry about empty strings and zero. I believe …

chipx86chipx86

We should probably catch errors for all these commands.

chipx86chipx86

Missing a trailing period.

chipx86chipx86

No blank line here.

chipx86chipx86

We use dumps to serialize, but are loading above with a custom split. dumps may be too heavy. Can we …

chipx86chipx86

"ensures"

chipx86chipx86

Swap these.

chipx86chipx86

Missing a docstring.

chipx86chipx86

How about "Deletes the HTTP cache used for the API."

chipx86chipx86

Rather than this, how about a method on ApiCache for deleting the cache?

chipx86chipx86

Parameters should go on the line after the log message.

chipx86chipx86

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 13 E303 too many blank lines (2)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Should go up before logging.

chipx86chipx86

This blank line should be removed.

chipx86chipx86

""" on the next line.

chipx86chipx86

Instead of terminating the process, can we just not cache? RBTools is often run in places where it's locked down …

chipx86chipx86

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'urlopen' imported but unused

reviewbotreviewbot

undefined name 'urllib2'

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

'urlopen' imported but unused

reviewbotreviewbot

undefined name 'urllib2'

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Should catch sqlite3.Error here and die gracefully.

brenniebrennie

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

For consistency with the RB database, mind if we use cache_info?

chipx86chipx86

And api_cache.

chipx86chipx86

"URL"

chipx86chipx86

"URL"

chipx86chipx86

"If-None-Match"

chipx86chipx86

No blank line.

chipx86chipx86

No blank line.

chipx86chipx86

These are only available in Python 2.7+.

chipx86chipx86

"API"

chipx86chipx86

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 38 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 10 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 1 E303 too many blank lines (3)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (107 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (122 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (87 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (94 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (116 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (115 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 30 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E265 block comment should start with '# '

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

'win32com' imported but unused

reviewbotreviewbot

'windll' imported but unused

reviewbotreviewbot

'com' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 42.
  2. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  3. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 34
     E128 continuation line under-indented for visual indent
    
  4. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  5. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 13
     E303 too many blank lines (3)
    
  6. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 9
     E303 too many blank lines (2)
    
  7. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  8. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (88 > 79 characters)
    
  9. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 32
     E261 at least two spaces before inline comment
    
  10. rbtools/api/cache.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  11. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W391 blank line at end of file
    
  12. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  15. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  16. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  17. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  18. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  32. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
     local variable 'kernel' is assigned to but never used
    
  33. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
     undefined name 'kernal'
    
  34. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
     'win32com' imported but unused
    
  35. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
     'windll' imported but unused
    
  36. rbtools/utils/appdirs.py (Diff revision 1)
     
     
    Show all issues
     'com' imported but unused
    
  37. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/utils/appdirs.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 2)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 35.
  2. rbtools/api/cache.py (Diff revision 3)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. rbtools/api/cache.py (Diff revision 3)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  4. rbtools/api/cache.py (Diff revision 3)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  5. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  6. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  7. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  9. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  10. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  11. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  32. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 3)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/api/request.py
        rbtools/api/cache.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 4)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 34.
  2. rbtools/api/cache.py (Diff revision 5)
     
     
    Show all issues
    Col: 9
     E303 too many blank lines (2)
    
  3. rbtools/commands/clearcache.py (Diff revision 5)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  5. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  6. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  9. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  10. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  32. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 5)
     
     
    Show all issues
     'com' imported but unused
    
  35. setup.py (Diff revision 5)
     
     
    Show all issues
     'json' imported but unused
    
  36. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 6)
     
     
    Show all issues
     'com' imported but unused
    
  35. setup.py (Diff revision 6)
     
     
    Show all issues
     'json' imported but unused
    
  36. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 7)
     
     
    Show all issues
     'com' imported but unused
    
  35. setup.py (Diff revision 7)
     
     
    Show all issues
     'json' imported but unused
    
  36. 
      
brennie
brennie
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 33.
  2. rbtools/api/cache.py (Diff revision 8)
     
     
    Show all issues
    Col: 23
     E128 continuation line under-indented for visual indent
    
  3. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  5. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  9. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  31. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  32. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 8)
     
     
    Show all issues
     'com' imported but unused
    
  35. setup.py (Diff revision 8)
     
     
    Show all issues
     'json' imported but unused
    
  36. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 9)
     
     
    Show all issues
     'com' imported but unused
    
  35. setup.py (Diff revision 9)
     
     
    Show all issues
     'json' imported but unused
    
  36. 
      
david
  1. 
      
  2. docs/rbtools/rbt/commands/index.rst (Diff revision 9)
     
     
     
    Show all issues

    Switch these two. (cle before clo)

  3. rbtools/api/cache.py (Diff revision 9)
     
     
    Show all issues

    I know that this module is part of the standard library, but is it always guaranteed to work? I don't want users to have to install anything other than python.

    1. The shared C library behind sqlite3 is distributed with Python 2.5+.

  4. rbtools/api/cache.py (Diff revision 9)
     
     
     
     
     
     
     
    Show all issues

    Since this will be going into master, and we're bumping the minimum python version, you can change this to just be import json and use json.loads and json.dumps

  5. rbtools/api/cache.py (Diff revision 9)
     
     
    Show all issues

    except OSError as e:

  6. rbtools/api/cache.py (Diff revision 9)
     
     
    Show all issues

    This can go away.

  7. setup.py (Diff revision 9)
     
     
    Show all issues

    Can you alphabetize this list?

  8. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 10)
     
     
    Show all issues
     'com' imported but unused
    
  35. setup.py (Diff revision 10)
     
     
    Show all issues
     'json' imported but unused
    
  36. 
      
david
  1. This change looks pretty good to me, but I'd like some details on manual testing of the individual rbtools commands.

  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 11)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/rbt/commands/clearcache.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 12)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
chipx86
  1. <p>Looking pretty awesome!</p>
    <p>Caught some typos and style differences. The general logic looks pretty thorough and correct from what I can tell so far.</p>

    1. Hah. That's what I get for not reloading this page after deploying the fix for this... (Went crazy trying to figure out how this bug was still occurring at first.)

  2. docs/rbtools/index.rst (Diff revision 12)
     
     
     
     
    Show all issues

    These should each be using the :file: markup. (I know we don't have that above, but we should there as well.)

    :file:`~/.cache/.rbtools/apicache.db`
    
  3. docs/rbtools/rbt/commands/clearcache.rst (Diff revision 12)
     
     
    Show all issues

    We should maybe say the HTTP cache for the API.

  4. docs/rbtools/rbt/commands/index.rst (Diff revision 12)
     
     
    Show all issues

    This and the doc page should match the command: clear-cache

  5. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    We can just import os.

  6. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    This isn't part of Python, so it must go in import group #2.

  7. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    This is a Python standard library module, so it can go in the group above.

  8. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    What's the reason for setting __slots__ here?

    Generally speaking, there's rarely a reason to actually set this. It can be used for memory performance reasons, but unless we're expecting a large number of these to stick around in memory for a while, we probably don't gain enough to warrant here.

  9. rbtools/api/cache.py (Diff revision 12)
     
     
     
    Show all issues

    The function name and docstring sort of contradict each other.

  10. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
     
    Show all issues

    Might be worth mentioning that this is intended to be API-compatible with a urllib2's response object. Same with CachedResponse below.

    Also, maybe we should call this HTTPResponse? And CachedHTTPResponse below? Just to make it more specific. (Not sure, just floating the idea.)

  11. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    Can this be a @staticmethod on ApiCache?

  12. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    Trailing period at the end of the log message.

    Variable on the next line.

  13. rbtools/api/cache.py (Diff revision 12)
     
     
     
    Show all issues

    No blank line here.

  14. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
     
    Show all issues

    These could result in exceptions as well, right? Anything we should be catching here?

    Also, you could skip doing this connect twice by doing:

    cache_is_new = not os.path.exists(self.cache_path):
    
    if cache_is_new:
        # All the setup stuff for creating
    
    self.db = sqlite3.connect(...)
    
    if not cache_is_new:
        # Check version, etc.
    
  15. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    No blank line here.

  16. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    Unless we're explicitly needing to worry about the difference between None, empty strings, 0, etc., it's usually best to just do if entry:.

    Same below.

  17. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    No blank line.

  18. rbtools/api/cache.py (Diff revision 12)
     
     
     
    Show all issues

    In this particular case, it's fine to use \ instead of parens for line continuation.

  19. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    No blank line.

  20. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    "cacheable"

  21. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    No blank line.

  22. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    We return response in all of these cases. We should probably just do a single return response at the end.

    The code above that returns a CachedResponse can just assign that to response to take advantage of the single exit point.

  23. rbtools/api/cache.py (Diff revision 12)
     
     
     
    Show all issues

    Must be on one line. Doc generators will chop it off otherwise.

  24. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    I read this incorrectly at first. Can you add a small comment saying that we restore the old value below?

    Also, this isn't thread-safe. Not a massive deal right now, but potentially problematic later. Easily fixed with doing all this in a threading.Lock().

  25. rbtools/api/cache.py (Diff revision 12)
     
     
     
    Show all issues

    Blank line between these.

  26. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    expires can be a separate parameter.

  27. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    How about "The C locale is not available on this system. The 'Expires' header cannot be parsed."

  28. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    We should actually grab the old locale and set it, instead of calling resetlocale, in case the caller has actually set a custom locale before all this.

  29. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    No blank line before elif and else.

    Same below.

  30. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    "posterity's"

  31. rbtools/api/cache.py (Diff revision 12)
     
     
     
    Show all issues

    Should be on the same line.

    I'd rather not do the map/strip trick inline like this, and like the one above. Instead, can we make a utility function for parsing headr values, and use a list comprehension?

    return [
        s.strip()
        for s in headers.split(',')
    ]
    
  32. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    We don't need to check against None unless there's a reason to worry about empty strings and zero. I believe those values are just as None-worthy as None for our purposes.

  33. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    We should probably catch errors for all these commands.

    1. Do you mean specifically these two, all calls to execute in _create_schema, or all calls to execute in the ApiCache.

    2. Probably all calls. Things can go wrong, and it'd be better to present that in a controlled way.

  34. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    Missing a trailing period.

  35. rbtools/api/cache.py (Diff revision 12)
     
     
     
     
    Show all issues

    No blank line here.

  36. rbtools/api/cache.py (Diff revision 12)
     
     
    Show all issues

    We use dumps to serialize, but are loading above with a custom split. dumps may be too heavy. Can we just do a join?

  37. rbtools/api/request.py (Diff revision 12)
     
     
    Show all issues

    "ensures"

  38. rbtools/commands/clearcache.py (Diff revision 12)
     
     
     
    Show all issues

    Swap these.

  39. rbtools/commands/clearcache.py (Diff revision 12)
     
     
    Show all issues

    Missing a docstring.

  40. rbtools/commands/clearcache.py (Diff revision 12)
     
     
    Show all issues

    How about "Deletes the HTTP cache used for the API."

  41. rbtools/commands/clearcache.py (Diff revision 12)
     
     
    Show all issues

    Rather than this, how about a method on ApiCache for deleting the cache?

  42. rbtools/commands/clearcache.py (Diff revision 12)
     
     
     
    Show all issues

    Parameters should go on the line after the log message.

  43. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 34.
  2. rbtools/api/cache.py (Diff revision 13)
     
     
    Show all issues
    Col: 13
     E303 too many blank lines (2)
    
  3. rbtools/api/cache.py (Diff revision 13)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  5. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  6. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  9. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  10. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  32. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 13)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 14)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 15)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 16)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
chipx86
  1. Looking great! Only a few small things left.

  2. rbtools/api/cache.py (Diff revision 16)
     
     
    Show all issues

    Should go up before logging.

  3. rbtools/api/cache.py (Diff revision 16)
     
     
     
     
    Show all issues

    This blank line should be removed.

  4. rbtools/api/cache.py (Diff revision 16)
     
     
    Show all issues

    """ on the next line.

  5. rbtools/api/cache.py (Diff revision 16)
     
     
     
     
     
     
     
     
    Show all issues

    Instead of terminating the process, can we just not cache? RBTools is often run in places where it's locked down and would never be able to create a cache.

    1. APICache._die is only called in instances where something has gone wrong after connecting to the database. If a connection cannot be made to the db (see rbtools/api/cache.py lines 177--186), then _die is not called, and instead caching is disabled. Is this behaviour adequate.

    2. Yeah, I think that's okay. So long as the cache database is optional if it can't be written to.

  6. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/api/request.py (Diff revision 17)
     
     
    Show all issues
     'urlopen' imported but unused
    
  3. rbtools/api/request.py (Diff revision 17)
     
     
    Show all issues
     undefined name 'urllib2'
    
  4. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  5. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  6. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  9. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  10. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  32. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  33. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  34. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
     'win32com' imported but unused
    
  35. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
     'windll' imported but unused
    
  36. rbtools/utils/appdirs.py (Diff revision 17)
     
     
    Show all issues
     'com' imported but unused
    
  37. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/api/request.py (Diff revision 18)
     
     
    Show all issues
     'urlopen' imported but unused
    
  3. rbtools/api/request.py (Diff revision 18)
     
     
    Show all issues
     undefined name 'urllib2'
    
  4. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  5. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  6. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  8. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  9. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  10. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  30. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  31. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  32. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  33. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  34. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
     'win32com' imported but unused
    
  35. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
     'windll' imported but unused
    
  36. rbtools/utils/appdirs.py (Diff revision 18)
     
     
    Show all issues
     'com' imported but unused
    
  37. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 19)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
brennie
  1. 
      
  2. rbtools/api/cache.py (Diff revision 19)
     
     
    Show all issues

    Should catch sqlite3.Error here and die gracefully.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/testbase.py
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/testbase.py
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 20)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
chipx86
  1. A few things I didn't catch before. I don't see anything beyond these though. :)

  2. rbtools/api/cache.py (Diff revision 20)
     
     
    Show all issues

    For consistency with the RB database, mind if we use cache_info?

  3. rbtools/api/cache.py (Diff revision 20)
     
     
    Show all issues

    And api_cache.

  4. rbtools/api/tests.py (Diff revision 20)
     
     
    Show all issues

    "URL"

  5. rbtools/api/tests.py (Diff revision 20)
     
     
    Show all issues

    "URL"

  6. rbtools/api/tests.py (Diff revision 20)
     
     
    Show all issues

    "If-None-Match"

  7. rbtools/api/tests.py (Diff revision 20)
     
     
     
     
    Show all issues

    No blank line.

  8. rbtools/api/tests.py (Diff revision 20)
     
     
     
     
    Show all issues

    No blank line.

  9. rbtools/api/tests.py (Diff revision 20)
     
     
     
    Show all issues

    These are only available in Python 2.7+.

  10. rbtools/commands/clearcache.py (Diff revision 20)
     
     
    Show all issues

    "API"

  11. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/tests.py
        rbtools/utils/appdirs.py
        rbtools/commands/clearcache.py
        rbtools/api/cache.py
        setup.py
        rbtools/api/request.py
    
    Ignored Files:
        rbtools/utils/COPYING.appdirs
        docs/rbtools/rbt/commands/clear-cache.rst
        rbtools/utils/README.appdirs
        docs/rbtools/rbt/commands/index.rst
        docs/rbtools/index.rst
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 32.
  2. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  3. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (93 > 79 characters)
    
  4. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 38
     E261 at least two spaces before inline comment
    
  5. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 10
     E261 at least two spaces before inline comment
    
  7. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 1
     E303 too many blank lines (3)
    
  8. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  9. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (107 > 79 characters)
    
  10. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (122 > 79 characters)
    
  11. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (87 > 79 characters)
    
  12. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  13. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (94 > 79 characters)
    
  14. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  15. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  16. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  17. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  18. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  19. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  20. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (85 > 79 characters)
    
  21. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (89 > 79 characters)
    
  22. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (116 > 79 characters)
    
  23. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  24. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  25. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  26. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  27. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (115 > 79 characters)
    
  28. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  29. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 30
     E128 continuation line under-indented for visual indent
    
  30. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 1
     E265 block comment should start with '# '
    
  31. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  32. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
     'win32com' imported but unused
    
  33. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
     'windll' imported but unused
    
  34. rbtools/utils/appdirs.py (Diff revision 21)
     
     
    Show all issues
     'com' imported but unused
    
  35. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to master (a630b0e)