Summary

Add support for ClearCase lbtype comparison

Review Request #6500 — Created Oct. 24, 2014 and submitted Oct. 26, 2014, 1:14 p.m.

Information

Owner

delyn

Repository

RBTools

Branch

release-0.6.x

Bugs

3179

Depends On

Commit

ea7f58d...

Reviewers

Groups

rbtools

People

Description

Identify all elements belonging to previous and current labels thanks to cleartool find -exec cleartool desc command.
Then for each element, attach these versions or default one "/main/0" (when a file was added or removed).
Add only versions not matching to the changeset.
When one label is provided, set a temporary label on current directory before proceeding to label comparison. This label is removed when a error happen eg. current directory contains checked out elements.

Testing Done

tested done within a clearcase dynamic view and a snapshot view from a linux machine

rbt diff generation between one label and current => OK
rbt diff generation between two labels => OK

rbt post on a reviewboard server 2.0.0 => OK
rbt post on a reviewboard server 1.7.6 with this patch using rbtools release-0.6.2 + 5defd0c + 30b0194

error message when root dir is checked out => OK
error message when any element under root dir is checked out => OK

Label comparison failed because:
ClearCase backend cannot set label when some elements are checked out:
<element xxx>

Issues

Description	From	Last Updated
Col: 54 E502 the backslash is redundant between brackets	reviewbot	Oct. 24, 2014, 10:36 a.m.
Col: 31 E127 continuation line over-indented for visual indent	reviewbot	Oct. 24, 2014, 10:36 a.m.
Col: 53 E502 the backslash is redundant between brackets	reviewbot	Oct. 24, 2014, 10:36 a.m.
Col: 21 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Oct. 24, 2014, 10:36 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Oct. 24, 2014, 10:36 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Oct. 24, 2014, 10:36 a.m.
Col: 51 E128 continuation line under-indented for visual indent	reviewbot	Oct. 24, 2014, 10:37 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Oct. 24, 2014, 10:37 a.m.
Col: 21 E128 continuation line under-indented for visual indent	reviewbot	Oct. 24, 2014, 10:37 a.m.
Col: 29 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 24, 2014, 10:39 a.m.
Col: 29 E126 continuation line over-indented for hanging indent	reviewbot	Oct. 24, 2014, 10:39 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 24, 2014, 10:42 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Oct. 24, 2014, 10:42 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py

rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 54
 E502 the backslash is redundant between brackets
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 31
 E127 continuation line over-indented for visual indent
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 53
 E502 the backslash is redundant between brackets
```

rbtools/clients/clearcase.py (Diff revision 1)

The issue has been resolved. Show all issues

Col: 21
 E123 closing bracket does not match indentation of opening bracket's line

rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 51
 E128 continuation line under-indented for visual indent
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
rbtools/clients/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E128 continuation line under-indented for visual indent
```

Change Summary:

fix pep8 and pyflakes errors reported by reviewbot

no regression on diff generation

Diff:

Revision 2 (+305 -4)

Show changes

rbtools/clients/clearcase.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py

rbtools/clients/clearcase.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 29
 E126 continuation line over-indented for hanging indent
```
rbtools/clients/clearcase.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 29
 E126 continuation line over-indented for hanging indent
```

Change Summary:

revert indentation, IMHO would rather like a too long line (few characters) rather than a bad indentation

Diff:

Revision 3 (+305 -4)

Show changes

rbtools/clients/clearcase.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py

rbtools/clients/clearcase.py (Diff revision 3)

The issue has been dropped. Show all issues

Col: 80
 E501 line too long (81 > 79 characters)

delyn Oct. 24, 2014, 10:42 a.m.

revert indentation, IMHO would rather like a too long line (few characters) rather than a bad indentation

rbtools/clients/clearcase.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
1. DE
  
  delyn Oct. 24, 2014, 10:42 a.m.
  same remark

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (22aaf41)