Add support for ClearCase lbtype comparison
Review Request #6500 — Created Oct. 24, 2014 and submitted
Identify all elements belonging to previous and current labels thanks to cleartool find -exec cleartool desc command.
Then for each element, attach these versions or default one "/main/0" (when a file was added or removed).
Add only versions not matching to the changeset.
When one label is provided, set a temporary label on current directory before proceeding to label comparison. This label is removed when a error happen eg. current directory contains checked out elements.
tested done within a clearcase dynamic view and a snapshot view from a linux machine
rbt diff generation between one label and current => OK
rbt diff generation between two labels => OKrbt post on a reviewboard server 2.0.0 => OK
rbt post on a reviewboard server 1.7.6 with this patch using rbtools release-0.6.2 + 5defd0c + 30b0194error message when root dir is checked out => OK
error message when any element under root dir is checked out => OKLabel comparison failed because:
ClearCase backend cannot set label when some elements are checked out:
<element xxx>
| Description | From | Last Updated |
|---|---|---|
|
Col: 54 E502 the backslash is redundant between brackets |
 reviewbot
|
|
|
Col: 31 E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
Col: 53 E502 the backslash is redundant between brackets |
reviewbot
|
|
|
Col: 21 E123 closing bracket does not match indentation of opening bracket's line |
reviewbot
|
|
|
Col: 80 E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (85 > 79 characters) |
reviewbot
|
|
|
Col: 51 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 21 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 29 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
Col: 29 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
DE
- Change Summary:
-
fix pep8 and pyflakes errors reported by reviewbot
no regression on diff generation
- Diff:
-
Revision 2 (+305 -4)
DE
- Change Summary:
-
revert indentation, IMHO would rather like a too long line (few characters) rather than a bad indentation
- Diff:
-
Revision 3 (+305 -4)
Tool: Pyflakes Processed Files: rbtools/clients/clearcase.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/clearcase.py