• 
      

    Fix selecting text within a single line in the diff viewer.

    Review Request #6492 — Created Oct. 23, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    e34f567...

    Reviewers

    The new text selection code only worked if the selected text had a <tr>
    in it. If it didn't, we'd end up with an empty clipboard.

    We now check for this condition, and just grab the text contents of the
    selection.

    Selected multiple lines. Verified it worked fine.

    Selected a word within a line. Also fine.

    Selected text within a line spanning different <span> tags. No problem.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/textCommentRowSelector.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/textCommentRowSelector.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (338807e)