• 
      

    Fix issues around the Whitespace Only logic and presentation.

    Review Request #6485 — Created Oct. 22, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    c358c21...

    Reviewers

    If a file was processed that had no chunks, it would be listed as
    whitespace-only. This was because the logic computing this would default
    to whitespace-only, and then override that if it found any non-equal
    chunks that contained real changes. For empty files, there were no
    chunks to process, so this flag would be incorrectly set.

    Even if the flag was correctly set, it still looked broken, as the
    message describing that it's whitespace-only would be hidden by default.
    The CSS rule for this has been removed.

    While here, I also fixed up the labels for the toggles to not have such
    varying mixed caps. That's been bugging me.

    Viewed an interdiff that resulted in files without chunks. They no longer
    appeared as whitespace-only.

    For valid files with that flag set, I saw the helpful text.

    The toggles stopped bothering me as much (though they still bother me.)

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/diffviewer/diffutils.py
      
      Ignored Files:
          reviewboard/templates/diffviewer/view_diff.html
          reviewboard/static/rb/css/diffviewer.less
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/diffviewer/diffutils.py
      
      Ignored Files:
          reviewboard/templates/diffviewer/view_diff.html
          reviewboard/static/rb/css/diffviewer.less
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (b354af6)