-
-
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
-
-
Switch to using ForwardingCacheBackend for all cache requests.
Review Request #6482 — Created Oct. 21, 2014 and submitted
| Information | |
|---|---|
| chipx86 | |
| Review Board | |
| release-2.0.x | |
|
|
|
| cd034a8... | |
| Reviewers | |
| reviewboard | |
We now force ForwardingCacheBackend as the default cache backend, and
instead work with the 'forwarded_backend' cache name when looking up or
saving the real cache backend.This covers the configuration forms, cache stats, and initial settings
population.
Successfully loaded my cache settings.
Switched caches in the UI and reloaded the stats page. Saw that it
immediately updated for the current cache settings.Started up memcached in verbose mode. Switched from local memory caching
to memcached and immediately saw operations on memcached.
| Description | From | Last Updated |
|---|---|---|
|
'django_reset' imported but unused |
 reviewbot
|
|
|
Can me merge this with the stuff below? It seems weird to set CACHES['default'] here and then change it later. |
 david
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'PIPELINE_CSS' imported but unused |
reviewbot
|
|
|
'PIPELINE_JS' imported but unused |
reviewbot
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
'PIPELINE_CSS' imported but unused |
reviewbot
|
|
|
'PIPELINE_JS' imported but unused |
reviewbot
|
-
-
reviewboard/settings.py (Diff revision 1) Can me merge this with the stuff below? It seems weird to set CACHES['default'] here and then change it later.
Change Summary:
Improve the comments to make it more clear what we're doing with CACHES.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+29 -7) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/admin/cache_stats.py reviewboard/admin/views.py reviewboard/settings.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/admin/cache_stats.py reviewboard/admin/views.py reviewboard/settings.py -
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
-
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/admin/cache_stats.py reviewboard/admin/views.py reviewboard/settings.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/admin/cache_stats.py reviewboard/admin/views.py reviewboard/settings.py