Switch to using ForwardingCacheBackend for all cache requests.

Review Request #6482 — Created Oct. 21, 2014 and submitted

Information

Review Board
release-2.0.x
cd034a8...

Reviewers

We now force ForwardingCacheBackend as the default cache backend, and
instead work with the 'forwarded_backend' cache name when looking up or
saving the real cache backend.

This covers the configuration forms, cache stats, and initial settings
population.

Successfully loaded my cache settings.

Switched caches in the UI and reloaded the stats page. Saw that it
immediately updated for the current cache settings.

Started up memcached in verbose mode. Switched from local memory caching
to memcached and immediately saw operations on memcached.

Description From Last Updated

'django_reset' imported but unused

reviewbotreviewbot

Can me merge this with the stuff below? It seems weird to set CACHES['default'] here and then change it later.

daviddavid

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot

'django_reset' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/forms.py
        reviewboard/admin/cache_stats.py
        reviewboard/admin/views.py
        reviewboard/settings.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/forms.py
        reviewboard/admin/cache_stats.py
        reviewboard/admin/views.py
        reviewboard/settings.py
    
    
  2. reviewboard/settings.py (Diff revision 1)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 1)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. reviewboard/settings.py (Diff revision 1)
     
     
     'PIPELINE_CSS' imported but unused
    
  5. reviewboard/settings.py (Diff revision 1)
     
     
     'PIPELINE_JS' imported but unused
    
  6. 
      
david
  1. 
      
  2. reviewboard/settings.py (Diff revision 1)
     
     
     
     
     
     
     
     
     

    Can me merge this with the stuff below? It seems weird to set CACHES['default'] here and then change it later.

    1. This is intentional. It's because settings_local.py may (very very likely) override in here. We want to have a default, let the user override, and then switch around after they can't do any more damage.

    2. Can you change the comments?

  3. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/forms.py
        reviewboard/admin/cache_stats.py
        reviewboard/admin/views.py
        reviewboard/settings.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/forms.py
        reviewboard/admin/cache_stats.py
        reviewboard/admin/views.py
        reviewboard/settings.py
    
    
  2. reviewboard/settings.py (Diff revision 2)
     
     
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 2)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
  4. reviewboard/settings.py (Diff revision 2)
     
     
     'PIPELINE_CSS' imported but unused
    
  5. reviewboard/settings.py (Diff revision 2)
     
     
     'PIPELINE_JS' imported but unused
    
  6. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (e49c874)
Loading...