Summary

Switch to using ForwardingCacheBackend for all cache requests.

Review Request #6482 — Created Oct. 21, 2014 and submitted Oct. 21, 2014, 4:55 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

~~6481~~, ~~6480~~

Commit

cd034a8...

Reviewers

Groups

reviewboard

People

Description

We now force ForwardingCacheBackend as the default cache backend, and
instead work with the 'forwarded_backend' cache name when looking up or
saving the real cache backend.

This covers the configuration forms, cache stats, and initial settings
population.

Testing Done

Successfully loaded my cache settings.

Switched caches in the UI and reloaded the stats page. Saw that it
immediately updated for the current cache settings.

Started up memcached in verbose mode. Switched from local memory caching
to memcached and immediately saw operations on memcached.

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Oct. 21, 2014, 3:22 p.m.
Can me merge this with the stuff below? It seems weird to set CACHES['default'] here and then change it later.	david	Oct. 21, 2014, 3:39 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 21, 2014, 3:22 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Oct. 21, 2014, 3:22 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Oct. 21, 2014, 3:22 p.m.
'django_reset' imported but unused	reviewbot	Oct. 21, 2014, 4:30 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Oct. 21, 2014, 4:30 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Oct. 21, 2014, 4:30 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Oct. 21, 2014, 4:30 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/admin/cache_stats.py
    reviewboard/admin/views.py
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/admin/cache_stats.py
    reviewboard/admin/views.py
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

reviewboard/settings.py (Diff revision 1)

The issue has been dropped. Show all issues

Can me merge this with the stuff below? It seems weird to set CACHES['default'] here and then change it later.

chipx86 Oct. 21, 2014, 3:39 p.m.

This is intentional. It's because settings_local.py may (very very likely) override in here. We want to have a default, let the user override, and then switch around after they can't do any more damage.

david Oct. 21, 2014, 3:40 p.m.
```
Can you change the comments?
```

Change Summary:

Improve the comments to make it more clear what we're doing with CACHES.

Commit:

1b35ea3c5b544abc27ecad59e9871b1342629bb2

cd034a87d34e53f0be1dc8bf47c10e82c065c34d

Diff:

Revision 2 (+29 -7)

Show changes

	reviewboard/settings.py
	reviewboard/admin/cache_stats.py
	reviewboard/admin/forms.py
	reviewboard/admin/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/admin/cache_stats.py
    reviewboard/admin/views.py
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/admin/cache_stats.py
    reviewboard/admin/views.py
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (e49c874)