Add optional Markdown support for the comment dialog.
Review Request #6479 — Created Oct. 21, 2014 and submitted
The comment dialog now includes an "Enable Markdown" checkbox for
choosing whether the comment should be in Markdown format. The
TextEditorView used will reflect that setting, transitioning between
CodeMirror and a native textarea.Unit tests have been added to test that functionality works for all the
various states.
Unit tests pass.
Tested this optional manually, and checked the database for the richText flag
results.
| Description | From | Last Updated |
|---|---|---|
|
You need to add handling for alt+M here, right? |
david
|
Review request changed
- Change Summary:
-
Add an explicit key binding for alt-M.
We actually could just use
accesskey=for this, which we are anyway, but different browsers use different modifiers, so.. I guess we're being nice and redundant. Not that it works on the Mac. - Commit:
-
8961b7a9bb7a89227123a11b9413c92f15a81a087db834141fb9fa286140bc312912b421e2174fac
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/models/commentEditorModel.js reviewboard/static/rb/js/models/tests/commentEditorModelTests.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/models/commentEditorModel.js reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/models/commentEditorModel.js reviewboard/static/rb/js/models/tests/commentEditorModelTests.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/models/commentEditorModel.js reviewboard/static/rb/js/models/tests/commentEditorModelTests.js