Add optional Markdown support for the comment dialog.

Review Request #6479 — Created Oct. 21, 2014 and submitted

Information

Review Board
release-2.0.x
7db8341...

Reviewers

The comment dialog now includes an "Enable Markdown" checkbox for
choosing whether the comment should be in Markdown format. The
TextEditorView used will reflect that setting, transitioning between
CodeMirror and a native textarea.

Unit tests have been added to test that functionality works for all the
various states.

Unit tests pass.

Tested this optional manually, and checked the database for the richText flag
results.

Description From Last Updated

You need to add handling for alt+M here, right?

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/commentEditorModel.js
        reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/commentEditorModel.js
        reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/static/rb/js/views/commentDialogView.js (Diff revision 1)
     
     
     
     
     
     
     
    Show all issues

    You need to add handling for alt+M here, right?

  3. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/commentEditorModel.js
        reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/commentEditorModel.js
        reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to markdown-redesign (eb00bd0)