Fix unit test failures with TextEditorView usage.
Review Request #6470 — Created Oct. 20, 2014 and submitted
Some of the unit tests were breaking with the transition to
TextEditorView, in particular with the plain text backend. In some
cases, they were expecting access to methods that no longer existed, or
looking up the wrong data key.This did expose a real bug in the change event handling, which now looks
for key events as well as change events, and allows the events to bubble
so that key bindings work.
Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
Old debug code? |
david
|
Review request changed
- Change Summary:
-
Removed debug code.
- Commit:
-
a10f2a95739a059b15a8e46df0e166317c26e09bff0452cde8496d1d109c5c7f8a7e6ddf6ee77576
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewRequestEditorView.js
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewRequestEditorView.js