Fix some style-related issue with the Markdown links and fields.
Review Request #6468 — Created Oct. 19, 2014 and submitted
The Markdown reference links were just a bit too high up, which was
more noticeable now that we have a checkbox. This fixes them to be
better aligned.Plain text fields were also getting a minimum height when they shouldn't
have, due to the way we checked for the presence of a minHeight option.
This resulted in the minHeight being set to the default of 70 when 0 was
passed. We now check for the existence by comparing to undefined.
Checked the Markdown Reference links on all fields and in the comment
dialog. Saw that it was properly positioned everywhere.Opened a plain text field with only one line of text and saw that it
had the proper height, matching what the Markdown equivalent had.
Review request changed
- Change Summary:
-
- Fixed change description.
- Diff now shows textEditorView.js changes properly.
- Description:
-
The Markdown reference links were just a bit too high up, which was
~ more noticeable now that we have a checkbox. This fixes thm to be ~ more noticeable now that we have a checkbox. This fixes them to be better aligned. Plain text fields were also getting a minimum height when they shouldn't
have, due to the way we checked for the presence of a minHeight option. This resulted in the minHeight being set to the default of 70 when 0 was ~ pssed. We now check for the existence by comparing to undefined. ~ passed. We now check for the existence by comparing to undefined. - Commit:
-
1d05b198c3c293da579ac9f7afae57088d8d2b24a7922e2356f52ab312d14f5f891f234d77a2fccb
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/ui/views/textEditorView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/ui/views/textEditorView.js