Summary

Fix : Issue 3558: RB doesn't handle paths containing spaces correctly

Review Request #6466 — Created Oct. 19, 2014 and submitted Oct. 23, 2014, 12:04 p.m.

Information

Owner

gheaeckkseqrz

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix : Issue 3558: RB doesn't handle paths containing spaces correctly

This is not perfect, but this should fix 99% of the cases.
This will still crash if path looks like /path/to b/your/file, but I can't find a way to fix this.

Testing Done

Tested with the dev server.

Issues

Description	From	Last Updated
Col: 53 E261 at least two spaces before inline comment	reviewbot	Oct. 19, 2014, 8:48 p.m.
Col: 80 E501 line too long (179 > 79 characters)	reviewbot	Oct. 19, 2014, 8:48 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/git.py



Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/git.py

reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 53
 E261 at least two spaces before inline comment
```
reviewboard/scmtools/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (179 > 79 characters)
```

Diff:

Revision 2 (+4 -5)

Show changes

reviewboard/scmtools/git.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/git.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/git.py

Status: Discarded

Status: Re-opened

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (de3bbf7)

reviewboard/scmtools/git.py (Diff revision 1)

reviewboard/scmtools/git.py (Diff revision 1)