Fix : Issue 3558: RB doesn't handle paths containing spaces correctly

Review Request #6466 — Created Oct. 19, 2014 and submitted

Information

Review Board

Reviewers

Fix : Issue 3558: RB doesn't handle paths containing spaces correctly

This is not perfect, but this should fix 99% of the cases.
This will still crash if path looks like /path/to b/your/file, but I can't find a way to fix this.

Tested with the dev server.

Description From Last Updated

Col: 53 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 80 E501 line too long (179 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/git.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/git.py
    
    
  2. reviewboard/scmtools/git.py (Diff revision 1)
     
     
    Show all issues
    Col: 53
     E261 at least two spaces before inline comment
    
  3. reviewboard/scmtools/git.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (179 > 79 characters)
    
  4. 
      
GH
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/git.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/git.py
    
    
  2. 
      
GH
GH
david
  1. Ship It!

  2. 
      
GH
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (de3bbf7)