Introduce TextEditorView, which supports both Markdown and plain text.
Review Request #6465 — Created Oct. 19, 2014 and submitted
MarkdownEditorView has been renamed and modified to support editing both
Markdown (through CodeMirror) and plain text (through<textarea>). This
edit mode can be set dynamically, allowing a user to choose how whether
a particular field is in rich text mode.Currently, the default is plain text, which means that when used, all
editors for new objects will show a standard<textarea>. This will
change as I port things over to use the new API.When placed in an inlineEditor, there will be an "Enable Markdown"
checkbox that the user may check to go in and out of rich text mode.
Tested (along with an upcoming change) in comment dialogs, review request
fields, reviews, replies. Toggled the checkbox and saw smooth transitions
between the entry widgets.Tested on Chrome and Firefox.
Change Summary:
Tidied up some code. Had this in my editor, but I didn't save.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+740 -283) |
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js
Change Summary:
Fix handling resize event propagation of plain textareas.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+744 -283) |
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js
-
-
reviewboard/static/rb/js/ui/views/textEditorView.js (Diff revision 3) This isn't necessarily CodeMirror (it should probably say "editor wrapper").
-
Change Summary:
Fixed docs that weren't updated from MarkdownEditorView.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+744 -283) |
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/views/reviewReplyEditorView.js reviewboard/static/rb/css/reviews.less reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/reviewDialogView.js reviewboard/static/rb/css/common.less reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js reviewboard/static/rb/js/ui/views/textEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/views/markdownEditorView.js