Summary

Introduce TextEditorView, which supports both Markdown and plain text.

Review Request #6465 — Created Oct. 19, 2014 and submitted Oct. 20, 2014, 11:35 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

c4fbb11...

Reviewers

Groups

reviewboard

People

Description

MarkdownEditorView has been renamed and modified to support editing both
Markdown (through CodeMirror) and plain text (through <textarea>). This
edit mode can be set dynamically, allowing a user to choose how whether
a particular field is in rich text mode.

Currently, the default is plain text, which means that when used, all
editors for new objects will show a standard <textarea>. This will
change as I port things over to use the new API.

When placed in an inlineEditor, there will be an "Enable Markdown"
checkbox that the user may check to go in and out of rich text mode.

Testing Done

Tested (along with an upcoming change) in comment dialogs, review request
fields, reviews, replies. Toggled the checkbox and saw smooth transitions
between the entry widgets.

Tested on Chrome and Firefox.

Files

Issues

Description	From	Last Updated
This isn't necessarily CodeMirror (it should probably say "editor wrapper").	david	Oct. 19, 2014, 2:01 p.m.
Same here.	david	Oct. 19, 2014, 2:01 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Change Summary:

Tidied up some code. Had this in my editor, but I didn't save.

Commit:

701b458ebe3a5bd8fea862b6842efe18a73ca60f

eab430c85b0a1ddf5c8754c8dbe6681362c1fc99

Diff:

Revision 2 (+740 -283)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/ui/views/textEditorView.js
	reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
	reviewboard/static/rb/js/views/commentDialogView.js
	reviewboard/static/rb/js/views/markdownEditorView.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Change Summary:

Fix handling resize event propagation of plain textareas.

Commit:

eab430c85b0a1ddf5c8754c8dbe6681362c1fc99

e0e22a20b64d3999de9a3eeb231cc590f95afdda

Diff:

Revision 3 (+744 -283)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/ui/views/textEditorView.js
	reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
	reviewboard/static/rb/js/views/commentDialogView.js
	reviewboard/static/rb/js/views/markdownEditorView.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

reviewboard/static/rb/js/ui/views/textEditorView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
This isn't necessarily CodeMirror (it should probably say "editor wrapper").
```
reviewboard/static/rb/js/ui/views/textEditorView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Same here.
```

Change Summary:

Fixed docs that weren't updated from MarkdownEditorView.

Commit:

e0e22a20b64d3999de9a3eeb231cc590f95afdda

c4fbb11d5cc0cb32b6bef95016561bba355638be

Diff:

Revision 4 (+744 -283)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/common.less
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/ui/views/textEditorView.js
	reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
	reviewboard/static/rb/js/views/commentDialogView.js
	reviewboard/static/rb/js/views/markdownEditorView.js
	reviewboard/static/rb/js/views/reviewDialogView.js
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.js
    reviewboard/static/rb/js/ui/views/textEditorView.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/markdownEditorView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to markdown-redesign (2ed30b1)