• 
      

    Fix a regression in saving comments.

    Review Request #6457 — Created Oct. 17, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    5d6bb61...

    Reviewers

    The new delayed notifications for "change" events from MarkdownEditor
    could result in text being chopped off if typing and saving within half
    a second. We now make sure to always set the latest-and-greatest text
    when saving, instead of relying on the handler for the "change" event.

    This only occurs in the comment dialog.

    Typed and hit enter quickly, and saw the text appear. Before, I could
    reliably reproduce the missing text issue.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/commentDialogView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/commentDialogView.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (c8dae3d)