• 
      

    Fix double escaping on file attachment captions.

    Review Request #6448 — Created Oct. 15, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    7a99ce6...

    Reviewers

    In review UIs, the caption text was getting double escaped. The reason for this
    was that we used a template to dump it into javascript, which would escape it
    once, and then called $.text(), which would escape it a second time. The fix
    here is to use the escapejs filter when templating the value into javascript.

    Created a file attachment with a caption that had some quotes in it, and
    verified that the visible header in the review UI didn't have the literal
    """.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/templates/reviews/ui/default.html
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/templates/reviews/ui/default.html
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (26c1770)