• 
      
    Fish Trophy

    chipx86 got a fish trophy!

    Fish Trophy

    Prevent various inline editors from vertically shifting on open/close.

    Review Request #6446 — Created Oct. 14, 2014 and submitted

    Information

    Review Board
    master
    e5c9b88...

    Reviewers

    The inline editors in various places (replies to reviews/comments and in
    the new review dialog) would shift a bit vertically when opening or
    closing the editor. This was due to the pencil disappearing and the line
    height shrinking where it used to be.

    We had this solved for banners. Now, that solution is contained in a
    macro, which is used in the other cases where we display these.

    Opened and closed editors in each case where I've found problems. They appeared
    cleanly without jumping.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/css/pages/reviews.less
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/css/pages/reviews.less
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (5e1acaf)