Fix further issues with missing file attachments.
Review Request #6444 — Created Oct. 15, 2014 and submitted
The previous fix for missing file attachments broke once the
f.close()
call was moved into thefinally:block if the file attachment was
missing, due to the fact that the initial statement failed andfwas
not a valid variable. This change fixes this by creating two separate
try/exceptblocks.It also sandboxes the generation of text-based file attachment comment
thumbnails, which would also break the page if the file was missing.
Tested on a review request where both issues were hit. I was able to
get the page to load.
-
In your change description, you have "the generation of text-based file attachment comment thumbnail generation"
Review request changed
- Description:
-
The previous fix for missing file attachments broke once the
f.close()call was moved into the finally:block if the file attachment wasmissing, due to the fact that the initial statement failed and fwasnot a valid variable. This change fixes this by creating two separate try/exceptblocks.It also sandboxes the generation of text-based file attachment comment
~ thumbnail generation, which would also break the page if the file was ~ thumbnails, which would also break the page if the file was missing. - missing.
Tool: Pyflakes Processed Files: reviewboard/reviews/ui/text.py reviewboard/attachments/mimetypes.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/ui/text.py reviewboard/attachments/mimetypes.py