Fix JavaScript unit tests for 2.0.x.
Review Request #6443 — Created Oct. 14, 2014 and submitted
A lot of the optimizations made resulted in broken unit tests, due to
various tests not accounting for throttled results.We now optimistically disable throttling where possible (for cases where
the _.throttle call isn't part of the object's prototype) and do proper
async testing in the other cases.
Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
Shouldn't this just be return cb;? |
 david
|
Change Summary:
Made our
_.throttleoverride less stupid.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+55 -33) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewBoxView.js reviewboard/templates/js/tests.html reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewBoxView.js reviewboard/templates/js/tests.html reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewBoxView.js reviewboard/templates/js/tests.html reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/views/reviewBoxView.js reviewboard/templates/js/tests.html reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js