• 
      

    Fix an occasional problem with the new CodeMirror optimizations.

    Review Request #6439 — Created Oct. 14, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    d798904...

    Reviewers

    We were throttling how often the 'change' event handler for CodeMirror
    was getting invoked. However, this meant that there was a window of time
    where CodeMirror could be closed/destroyed before the 'change' event
    handler was called.

    We now check for this and bail if CodeMirror is no longer with us.

    Could no longer reproduce the problem.

    Still saw change events firing.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/markdownEditorView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/markdownEditorView.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (f058131)