• 
      

    Preserve query args when redirecting from Review/Reply draft resources.

    Review Request #6437 — Created Oct. 14, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    6cf43db...

    Reviewers

    The Review/Reply Draft resources redirect to a resource with the
    appropriate ID, but when doing so, they don't preserve any query string
    arguments. This means that if something like ?api_format or
    ?force-text-type is used, it will be lost.

    We now have a useful utility function for building a URL that preserves
    all query string arguments that aren't automatically preserved by the
    base WebAPIResource. These are used in all two resources that do a
    redirect from a GET.

    Tested manually, and with an in-progress change that relies on this behavior.

    unit tests pass.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/base.py
          reviewboard/webapi/resources/review_reply_draft.py
          reviewboard/webapi/resources/review_draft.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/base.py
          reviewboard/webapi/resources/review_reply_draft.py
          reviewboard/webapi/resources/review_draft.py
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (3b58404)